aura: Use PlatformWindow from WindowTreeHost.

aura: Use PlatformWindow from WindowTreeHostWin.

With this patch, both Windows and Ozone implementations use PlatformWindow for
interacting with the native windowing system. Eventually, the X11 implementations
will also use this, and WindowTreeHost will have a single implementation on all
platforms.

BUG=none
R=ben@chromium.org

Previously landed in r284850, but reverted in r284905 because it broke a multi-
window ash unit-test on Windows. The test is now disabled (r284931).

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284986

[Ben Goodger (Google), 2014-07-21 17:39:50]

lgtm

https://codereview.chromium.org/400413002/diff/190001/ui/aura/aura.gyp
File ui/aura/aura.gyp (right):

https://codereview.chromium.org/400413002/diff/190001/ui/aura/aura.gyp#newcod...
ui/aura/aura.gyp:127: '../platform_window/win/win_window.gyp:win_window',
quick note... any reason you didn't provide a single gyp file for
platform_window? you've done all this work to provide a cross platform
encapsulation for a window but then when you use it you have to include
platform-specific gyp files...

[sadrul, 2014-07-22 20:43:29]

https://codereview.chromium.org/400413002/diff/190001/ui/aura/aura.gyp
File ui/aura/aura.gyp (right):

https://codereview.chromium.org/400413002/diff/190001/ui/aura/aura.gyp#newcod...
ui/aura/aura.gyp:127: '../platform_window/win/win_window.gyp:win_window',
On 2014/07/21 17:39:50, Ben Goodger (Google) wrote:
> quick note... any reason you didn't provide a single gyp file for
> platform_window? you've done all this work to provide a cross platform
> encapsulation for a window but then when you use it you have to include
> platform-specific gyp files...

It is necessary to have at least a separate x11_window target so that it can be
used from ozone. So I changed this to have a platform_window_base target,
x11_window and win_window to be on top of that, and another platform_window
target that depends on platform_window_base and win_window/x11_window. But the
debug build seems unable to build the platform_window target (see patchset#7,
failure log:
http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...).

[sadrul, 2014-07-23 02:19:15]

https://codereview.chromium.org/400413002/diff/190001/ui/aura/aura.gyp
File ui/aura/aura.gyp (right):

https://codereview.chromium.org/400413002/diff/190001/ui/aura/aura.gyp#newcod...
ui/aura/aura.gyp:127: '../platform_window/win/win_window.gyp:win_window',
On 2014/07/22 20:43:29, sadrul wrote:
> On 2014/07/21 17:39:50, Ben Goodger (Google) wrote:
> > quick note... any reason you didn't provide a single gyp file for
> > platform_window? you've done all this work to provide a cross platform
> > encapsulation for a window but then when you use it you have to include
> > platform-specific gyp files...
> 
> It is necessary to have at least a separate x11_window target so that it can
be
> used from ozone. So I changed this to have a platform_window_base target,
> x11_window and win_window to be on top of that, and another platform_window
> target that depends on platform_window_base and win_window/x11_window. But the
> debug build seems unable to build the platform_window target (see patchset#7,
> failure log:
>
http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...).

I was unable to figure out the build issues :(

I am going to take a look at this again (filed http://crbug.com/396406 to track
the work), but for now, I have reverted this change, and plan on landing it as
is.

[sadrul, 2014-07-23 06:04:08]

Committed patchset #8 manually as r284850 (presubmit successful).

[sadrul, 2014-07-23 17:51:50]

Committed patchset #9 manually as r284986 (presubmit successful).