Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 40038: Apply a security patch for ICU regex. (http://bugs.icu-project.org/trac/ticke... (Closed)

Created:
11 years, 9 months ago by jungshik at Google
Modified:
9 years, 7 months ago
Reviewers:
agl
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Apply a security patch for ICU regex. (http://bugs.icu-project.org/trac/ticket/6149). As far as I can tell, ICU regex is not used, but we may in the future and this patch is specifically made for ICU 3.8/3.8.1. So, there's no harm applying it. BUG=8198 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10949

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -32 lines) Patch
M third_party/icu38/README.google View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/icu38/source/common/uvectr32.h View 4 chunks +14 lines, -2 lines 0 comments Download
M third_party/icu38/source/common/uvectr32.cpp View 5 chunks +35 lines, -16 lines 0 comments Download
M third_party/icu38/source/i18n/regexcmp.cpp View 2 chunks +10 lines, -7 lines 0 comments Download
M third_party/icu38/source/i18n/rematch.cpp View 8 chunks +27 lines, -4 lines 0 comments Download
M third_party/icu38/source/test/intltest/regextst.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/icu38/source/test/intltest/regextst.cpp View 4 chunks +31 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
jungshik at Google
11 years, 9 months ago (2009-03-03 20:14:53 UTC) #1
agl
11 years, 9 months ago (2009-03-03 20:33:23 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698