Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 400353007: rendering_helper - Use real GLSurface and GLContext. (Closed)

Created:
6 years, 5 months ago by Owen Lin
Modified:
6 years, 5 months ago
Reviewers:
Pawel Osciak, piman
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

rendering_helper - Use real GLSurface and GLContext. BUG=None TEST=Run the vda_unitest on GLX and EGL machines. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284628

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -201 lines) Patch
M content/common/gpu/media/rendering_helper.h View 4 chunks +9 lines, -24 lines 0 comments Download
M content/common/gpu/media/rendering_helper.cc View 8 chunks +66 lines, -177 lines 0 comments Download
M content/common/gpu/media/video_decode_accelerator_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Owen Lin
PTAL. Thanks.
6 years, 5 months ago (2014-07-21 09:59:39 UTC) #1
piman
LGTM. Much better!
6 years, 5 months ago (2014-07-21 18:20:27 UTC) #2
Owen Lin
The CQ bit was checked by owenlin@chromium.org
6 years, 5 months ago (2014-07-22 02:06:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/owenlin@chromium.org/400353007/1
6 years, 5 months ago (2014-07-22 02:08:06 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 04:42:46 UTC) #5
Message was sent while issue was closed.
Change committed as 284628

Powered by Google App Engine
This is Rietveld 408576698