Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: Tools/GardeningServer/ui/ct-sheriff-o-matic.html

Issue 400353006: Fix a bunch of UI nits in sheriff-o-matic. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/GardeningServer/ui/ct-sheriff-o-matic.html
diff --git a/Tools/GardeningServer/ui/ct-sheriff-o-matic.html b/Tools/GardeningServer/ui/ct-sheriff-o-matic.html
index d3d73fc53343e32529c4f9e037a25ee2a67e9345..946ea0db1dcd068e534de9c9f08f46abdf942d80 100644
--- a/Tools/GardeningServer/ui/ct-sheriff-o-matic.html
+++ b/Tools/GardeningServer/ui/ct-sheriff-o-matic.html
@@ -17,27 +17,51 @@ found in the LICENSE file.
<link rel="import" href="../bower_components/core-animated-pages/core-animated-pages.html">
<link rel="import" href="../bower_components/core-animated-pages/transitions/slide-from-right.html">
-<link rel="import" href="../bower_components/paper-tabs/paper-tab.html">
-<link rel="import" href="../bower_components/paper-tabs/paper-tabs.html">
<link rel="import" href="ct-results-panel.html">
<link rel="import" href="ct-unexpected-failures.html">
<polymer-element name="ct-sheriff-o-matic">
<template>
<style>
- paper-tabs {
- background-color: #00bcd4;
- color: #fff;
- box-shadow: 0px 3px 2px rgba(0, 0, 0, 0.2);
+ :host {
+ display: flex;
+ flex-direction: column;
+ height: 100%;
+ }
+ header {
+ -webkit-user-select: none;
abarth-chromium 2014/07/21 06:17:37 We really should unprefix this.
ojan 2014/07/21 06:34:31 Yes. There's some incompatibility across browsers,
+ align-items: center;
+ background-color: #212121;
+ color: white;
+ cursor: default;
+ display: flex;
+ font-size: 1.1em;
+ }
+ header a, header span {
+ color: white;
+ display: inline-block;
+ padding: 0.25em 4px;
+ text-decoration: none;
+ }
+ core-animated-pages {
+ flex: 1;
}
</style>
- <paper-tabs selected="{{selected}}">
- <paper-tab>Unexpected Failures</paper-tab>
- <paper-tab>Results</paper-tab>
- </paper-tabs>
- <core-animated-pages selected="{{selected}}" transitions="slide-from-right">
- <ct-unexpected-failures on-ct-examine-failures="{{onExamine}}"></ct-unexpected-failures>
- <ct-results-panel failures="{{currentFailures}}"></ct-results-panel>
+
+ <header>
+ <template if="{{ selected == 0 }}">
+ <span><img src="../favicon.ico"> Auto-sheriff-o-maticon</span>
abarth-chromium 2014/07/21 06:17:37 Auto-sheriff-o-maticon ?
ojan 2014/07/21 06:34:31 We haven't figured out whether it will be auto-she
+ </template>
+ <template if="{{ selected == 1 }}">
+ <a on-click="{{ onBack }}">
+ &lt;&lt; Go back
+ </a>
+ </template>
+ </header>
+
+ <core-animated-pages selected="{{ selected }}" transitions="slide-from-right">
+ <ct-unexpected-failures on-ct-examine-failures="{{ onExamine }}"></ct-unexpected-failures>
+ <ct-results-panel failures="{{ currentFailures }}"></ct-results-panel>
</core-animated-pages>
</template>
<script>
@@ -45,6 +69,10 @@ found in the LICENSE file.
selected: 0,
currentFailures: [],
+ onBack: function() {
+ this.selected = 0;
+ },
+
onExamine: function(event) {
this.currentFailures = event.detail;
this.selected = 1;

Powered by Google App Engine
This is Rietveld 408576698