Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1734)

Unified Diff: Tools/GardeningServer/ui/ct-results-panel.html

Issue 400353006: Fix a bunch of UI nits in sheriff-o-matic. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/GardeningServer/ui/ct-results-panel.html
diff --git a/Tools/GardeningServer/ui/ct-results-panel.html b/Tools/GardeningServer/ui/ct-results-panel.html
index 6a0658c79ef10b28a5a115e28e8da6b5161a0c99..accb56f99339b1821c7df09542369889b2665a89 100644
--- a/Tools/GardeningServer/ui/ct-results-panel.html
+++ b/Tools/GardeningServer/ui/ct-results-panel.html
@@ -13,7 +13,8 @@ found in the LICENSE file.
<template>
<style>
:host {
- display: block;
+ display: flex;
+ flex-direction: column;
}
paper-item.core-selected {
@@ -21,21 +22,41 @@ found in the LICENSE file.
}
.message {
- text-align: center;
margin: 20px;
+ text-align: center;
+ }
+
+ core-menu {
+ box-shadow: 0 3px 3px #ccc;
+ /* Override /deep/ selector in core-menu.css. */
+ margin: 0 !important;
+ max-height: 20%;
+ min-height: 150px;
+ overflow: auto;
+ /* So the box-shadow goes on top of the results. */
+ z-index: 1;
+ }
+
+ .results {
+ /* Stay below the box shadow of the core-menu. */
+ padding-top: 6px;
+ flex: 1;
+ overflow: auto;
}
</style>
- <template if="{{!failures.length}}">
+ <template if="{{ !failures.length }}">
<div class="message">No results to display.</div>
</template>
- <template if="{{failures.length}}">
- <core-menu selected="{{selected}}">
- <template repeat="{{failure in failures}}">
- <paper-item label="{{failure.testName}}"></paper-item>
+ <template if="{{ failures.length }}">
+ <core-menu selected="{{ selected }}">
+ <template repeat="{{ failure in failures }}">
+ <paper-item label="{{ failure.testName }}"></paper-item>
</template>
</core-menu>
- <ct-embedded-flakiness-dashboard test="{{failures[selected].testName}}"></ct-embedded-flakiness-dashboard>
- <ct-results-by-builder failure="{{failures[selected]}}"></ct-results-by-builder>
+ <div class="results">
+ <ct-embedded-flakiness-dashboard test="{{ failures[selected].testName }}"></ct-embedded-flakiness-dashboard>
+ <ct-results-by-builder failure="{{ failures[selected] }}"></ct-results-by-builder>
+ </div>
</template>
</template>
<script>

Powered by Google App Engine
This is Rietveld 408576698