Fix a bunch of UI nits in sheriff-o-matic.

Fix a bunch of UI nits in sheriff-o-matic.

-Add back the dividers between failure cards.
The wall of text and buttons was overwhelming.
-Fix the heights of things so that the page contents
isn't all overflowing out of height:0 containers.
-Remove the useless divider in ct-builder-grid.
-Make the buttons look like esprehn's codereview tool.
-Add a new sheriff-friendly favicon.
-Have the results panel consist of two overflow:auto
regions. One for the menu and one for the results.
-Get rid of tabs on top. Instead have a header that
converts to a "go back" button when you are in the
results page.
-Have ct-tree-status be collapsed to 0 height when it's empty.
To make this work, have the default status be the empty
string so that the status attribute isn't removed when the value
is open.
-Fix ellipsizing CSS in ct-tree-status

NOTRY=true
R=abarth@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178539

[ojan, 2014-07-21 03:16:47]

This gets sheriff-o-matic to a minimally not hideous place. I welcome other's
doing follow-up work to make it actually pretty.

[abarth-chromium, 2014-07-21 06:17:37]

LGTM

Can you reverse the order of the stream too?

https://codereview.chromium.org/400353006/diff/1/Tools/GardeningServer/sherif...
File Tools/GardeningServer/sheriff-o-matic.html (right):

https://codereview.chromium.org/400353006/diff/1/Tools/GardeningServer/sherif...
Tools/GardeningServer/sheriff-o-matic.html:20: font-family: 'Open Sans';
Should we use Roboto?

https://codereview.chromium.org/400353006/diff/1/Tools/GardeningServer/ui/ct-...
File Tools/GardeningServer/ui/ct-sheriff-o-matic.html (right):

https://codereview.chromium.org/400353006/diff/1/Tools/GardeningServer/ui/ct-...
Tools/GardeningServer/ui/ct-sheriff-o-matic.html:32: -webkit-user-select: none;
We really should unprefix this.

https://codereview.chromium.org/400353006/diff/1/Tools/GardeningServer/ui/ct-...
Tools/GardeningServer/ui/ct-sheriff-o-matic.html:53: <span><img
src="../favicon.ico"> Auto-sheriff-o-maticon</span>
Auto-sheriff-o-maticon ?

[ojan, 2014-07-21 06:31:15]

The CQ bit was checked by ojan@chromium.org

[commit-bot: I haz the power, 2014-07-21 06:32:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ojan@chromium.org/400353006/1

[commit-bot: I haz the power, 2014-07-21 06:32:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-21 06:32:30]

Failed to apply patch for Tools/GardeningServer/ui/ct-tree-status.html:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Tools/GardeningServer/ui/ct-tree-status.html
  Hunk #1 FAILED at 6.
  Hunk #2 FAILED at 33.
  2 out of 2 hunks FAILED -- saving rejects to file
Tools/GardeningServer/ui/ct-tree-status.html.rej

Patch:       Tools/GardeningServer/ui/ct-tree-status.html
Index: Tools/GardeningServer/ui/ct-tree-status.html
diff --git a/Tools/GardeningServer/ui/ct-tree-status.html
b/Tools/GardeningServer/ui/ct-tree-status.html
index
0293c090bfce7ad7758bcdc7ab5e7624d1de773f..c2aec6791caffbc1ab2aa280fe3b12dc6a466c39
100644
--- a/Tools/GardeningServer/ui/ct-tree-status.html
+++ b/Tools/GardeningServer/ui/ct-tree-status.html
@@ -6,24 +6,21 @@ found in the LICENSE file.
 
 <polymer-element name="ct-tree-status">
   <template>
-    <template if="{{ message }}">
       <style>
         :host {
           display: block;
-          whitespace: nowrap;
-          overflow: hidden;
-          text-overflow: ellispis;
         }
 
         :host([status=throttled]) {
-          background-color: khaki;
+          background-color: #fffc6c;
         }
 
         :host([status=closed]) {
           color: white;
-          background-color: tomato;
+          background-color: #e98080;
         }
       </style>
+    <template if="{{ message }}">
       {{ project }}: {{ message }}
     </template>
   </template>
@@ -33,12 +30,13 @@ found in the LICENSE file.
         project: '',
         message: '',
         status: {
-          value: 'open',
+          value: '',
           reflect: true,
         },
       },
 
       update: function() {
+        // FIXME: Show a link to *-status.appspot.com.
         var url = treestatus.urlByName(this.project);
         return net.json(url).then(function(response) {
           this.updateStatus(response);

[ojan, 2014-07-21 06:34:32]

> Can you reverse the order of the stream too?

That's on the TODO list. I didn't want to make significant functional changes as
part of this patch.

https://codereview.chromium.org/400353006/diff/1/Tools/GardeningServer/sherif...
File Tools/GardeningServer/sheriff-o-matic.html (right):

https://codereview.chromium.org/400353006/diff/1/Tools/GardeningServer/sherif...
Tools/GardeningServer/sheriff-o-matic.html:20: font-family: 'Open Sans';
On 2014/07/21 06:17:37, abarth wrote:
> Should we use Roboto?

Sure, I'm going to land this now so I can go to bed. rslgtm on a change that
switches fonts.

https://codereview.chromium.org/400353006/diff/1/Tools/GardeningServer/ui/ct-...
File Tools/GardeningServer/ui/ct-sheriff-o-matic.html (right):

https://codereview.chromium.org/400353006/diff/1/Tools/GardeningServer/ui/ct-...
Tools/GardeningServer/ui/ct-sheriff-o-matic.html:32: -webkit-user-select: none;
On 2014/07/21 06:17:37, abarth wrote:
> We really should unprefix this.

Yes. There's some incompatibility across browsers, but i'm not sure we gain
anything by keeping it prefixed.

https://codereview.chromium.org/400353006/diff/1/Tools/GardeningServer/ui/ct-...
Tools/GardeningServer/ui/ct-sheriff-o-matic.html:53: <span><img
src="../favicon.ico"> Auto-sheriff-o-maticon</span>
On 2014/07/21 06:17:37, abarth wrote:
> Auto-sheriff-o-maticon ?

We haven't figured out whether it will be auto-sheriff or sheriff-o-matic. So, I
went with a silly name for now.

[ojan, 2014-07-21 06:46:23]

Committed patchset #1 manually as r178539 (presubmit successful).