tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index d51e0645a245845bb7e73e3b994bdfcbdbbf0277..6d5d3b2ced109651cf78f1115b0afc0f7d59bdb0 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -10233,6 +10233,17 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   </summary>
 </histogram>
 
+<histogram name="interstitial.ssl.captive_portal" enum="SSLCaptivePortal">
+  <owner>meacer@chromium.org</owner>
+  <summary>
+    Record possible states of captive portals. This histogram is emitted
+    whenever a ssl interstitial page is displayed and captive portal detection

[Mark P, 2014/08/14 19:57:27]

If I'm reading the enum correctly, these value overlap.
I think you should explicitly point that out here
perhaps add the remark
(possibly multiple times to different buckets)
immediately after "is emitted"

[radhikabhar, 2014/08/14 21:29:41]

Done.

+    is enabled. The captive portal technique forces a client on a network to see
+    a special web page (usually for authentication purposes) before using the
+    Internet normally.

[Mark P, 2014/08/14 19:57:27]

nit: lowercase internet

[radhikabhar, 2014/08/14 21:29:41]

Done.

+  </summary>
+</histogram>
+
 <histogram name="interstitial.ssl.cause.nonoverridable"
     enum="SSLNonAttackCauses">
   <owner>felt@chromium.org</owner>
@@ -48906,6 +48917,31 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   <int value="5" label="DEPRECATION_RAZE_FAILED">Raze failed.</int>
 </enum>
 
+<enum name="SSLCaptivePortal" type="int">
+  <int value="0"
+      label="Chrome captive portal detection enabled
+             (CAPTIVE_PORTAL_DETECTION_ENABLED)"/>
+  <int value="1"
+      label="Chrome captive portal detection enabled on an overridable SSL
+             error page (CAPTIVE_PORTAL_DETECTION_ENABLED_OVERRIDABLE)"/>
+  <int value="2"
+      label="Received a captive portal result

[Mark P, 2014/08/14 19:57:27]

This is not "Received a captive portal result", right?  That would actually
imply the "result" is a captive portal.  If so, that's the same as bucket 6. 
(We're on a captive portal and know it.)
Did you mean received the result of attempting to decide if page is a captive
portal?

ditto on 3.

[radhikabhar, 2014/08/14 21:29:41]

Done.

+             (CAPTIVE_PORTAL_PROBE_COMPLETED)"/>
+  <int value="3"
+      label="Received a captive portal result on an overridable SSL error
+             page (CAPTIVE_PORTAL_PROBE_COMPLETED_OVERRIDABLE)"/>
+  <int value="4"
+      label="Received no response or Non-HTTP login page
+             (CAPTIVE_PORTAL_NO_RESPONSE)"/>
+  <int value="5"
+      label="Received no response or Non-HTTP login page on an overridable
+             SSL error page (CAPTIVE_PORTAL_NO_RESPONSE_OVERRIDABLE)"/>
+  <int value="6" label="Detected captive portal (CAPTIVE_PORTAL_DETECTED)"/>
+  <int value="7"
+      label="Detected captive portal on an overridable SSL error page
+             (CAPTIVE_PORTAL_DETECTED_OVERRIDABLE)"/>
+</enum>
+
 <enum name="SSLCipherSuite" type="int">
   <summary>SSL/TLS cipher suites from the IANA registry</summary>
   <int value="0" label="TLS_NULL_WITH_NULL_NULL"/>
@@ -49302,26 +49338,28 @@ Therefore, the affected-histogram name has to have at least one dot in it.
       label="User manually typed proceed (PROCEED_MANUAL_NONOVERRIDABLE)"/>
   <int value="17"
       label="Chrome captive portal detection enabled
-             (CAPTIVE_PORTAL_DETECTION_ENABLED)"/>
+             (DEPRECATED_CAPTIVE_PORTAL_DETECTION_ENABLED)"/>
   <int value="18"
       label="Chrome captive portal detection enabled on an overridable SSL
-             error page (CAPTIVE_PORTAL_DETECTION_ENABLED_OVERRIDABLE)"/>
+             error page
+             (DEPRECATED_CAPTIVE_PORTAL_DETECTION_ENABLED_OVERRIDABLE)"/>
   <int value="19"
       label="Received a captive portal result
-             (CAPTIVE_PORTAL_PROBE_COMPLETED)"/>
+             (DEPRECATED_CAPTIVE_PORTAL_PROBE_COMPLETED)"/>
   <int value="20"
       label="Received a captive portal result on an overridable SSL error
-             page (CAPTIVE_PORTAL_PROBE_COMPLETED_OVERRIDABLE)"/>
+             page (DEPRECATED_CAPTIVE_PORTAL_PROBE_COMPLETED_OVERRIDABLE)"/>
   <int value="21"
       label="Received no response or Non-HTTP login page
-             (CAPTIVE_PORTAL_NO_RESPONSE)"/>
+             (DEPRECATED_CAPTIVE_PORTAL_NO_RESPONSE)"/>
   <int value="22"
       label="Received no response or Non-HTTP login page on an overridable
-             SSL error page (CAPTIVE_PORTAL_NO_RESPONSE_OVERRIDABLE)"/>
+             SSL error page
+             (DEPRECATED_CAPTIVE_PORTAL_NO_RESPONSE_OVERRIDABLE)"/>
   <int value="23" label="Detected captive portal (CAPTIVE_PORTAL_DETECTED)"/>
   <int value="24"
       label="Detected captive portal on an overridable SSL error page
-             (CAPTIVE_PORTAL_DETECTED_OVERRIDABLE)"/>
+             (DEPRECATED_CAPTIVE_PORTAL_DETECTED_OVERRIDABLE)"/>

[Mark P, 2014/08/14 19:57:27]

You didn't do anything.  By done, so that mean you don't have replacements for
these deprecated values?

[radhikabhar, 2014/08/14 21:29:41]

I created a new histogram for these deprecated values which is SSLCaptivePortal.
I don't have any replacement in this histogram but in the SSLCaptivePortal
Histogram.

 </enum>
 
 <enum name="StartupURLsMigration" type="int">