Issue 400313002: Fixes for re-enabling more MSVC level 4 warnings: misc edition #3

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 400313002: Fixes for re-enabling more MSVC level 4 warnings: misc edition #3 (Closed)

Created:
6 years, 5 months ago by Peter Kasting

Modified:
6 years, 5 months ago

Reviewers:
jamesr, tzik

CC:
chromium-reviews, cc-bugs_chromium.org, kinuko+fileapi, nhiroki, tzik

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixes for re-enabling more MSVC level 4 warnings: misc edition #3 This contains fixes for the following sorts of issues: * Signedness mismatch * Possibly-uninitialized local variable These are the warnings that have appeared in the codebase since I began uploading my first cleanup pass a few weeks ago. BUG=81439 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284378

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -6 lines)			Patch
	M	cc/surfaces/surface_aggregator_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc	View		1 chunk	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

jamesr: cc/surfaces/surface_aggregator_unittest.cc tzik: chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc

6 years, 5 months ago (2014-07-18 20:52:52 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkasting@chromium.org/400313002/1

6 years, 5 months ago (2014-07-20 15:03:38 UTC) #5

Message was sent while issue was closed.

Change committed as 284378

Expand Messages | Collapse Messages