Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 400293002: Write MacSandboxTest.OpenSSLAccess. (Closed)

Created:
6 years, 5 months ago by davidben
Modified:
6 years, 5 months ago
Reviewers:
jam, Ryan Sleevi
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

Write MacSandboxTest.OpenSSLAccess. Replaces MacSandboxTest.NSSAccess. With this, content_unittest links and this new test passes (modulo BoringSSL switchover fixes still pending). BUG=395231 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284266

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -1 line) Patch
M content/common/sandbox_mac_system_access_unittest.mm View 3 chunks +34 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
davidben
6 years, 5 months ago (2014-07-18 19:39:02 UTC) #1
Ryan Sleevi
LGTM, and this matches what Adam is doing in https://codereview.chromium.org/398543003 (since, at present, the /dev/urandom ...
6 years, 5 months ago (2014-07-18 19:44:03 UTC) #2
davidben
+jam for OWNERS
6 years, 5 months ago (2014-07-18 19:50:19 UTC) #3
jam
lgtm
6 years, 5 months ago (2014-07-18 21:40:00 UTC) #4
davidben
The CQ bit was checked by davidben@chromium.org
6 years, 5 months ago (2014-07-18 21:49:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/400293002/1
6 years, 5 months ago (2014-07-18 21:51:07 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-19 00:47:29 UTC) #7
Message was sent while issue was closed.
Change committed as 284266

Powered by Google App Engine
This is Rietveld 408576698