GN Windows build fixes

GN Windows build fixes

Reland of https://codereview.chromium.org/404603002/ but without the problematic extensions.gypi changes.

R=agl@chromium.org, dalecurtis@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284703

[brettw, 2014-07-18 17:23:01]

agl: boringssl one-liner
dale: everything else.

https://codereview.chromium.org/400233002/diff/1/media/BUILD.gn
File media/BUILD.gn (right):

https://codereview.chromium.org/400233002/diff/1/media/BUILD.gn#newcode77
media/BUILD.gn:77: if (is_win) {
For this, I prefer to unconditionally add configs and then make the config do
things or not depending on the platform, since it makes it easier to come by
later and add dependent settings for other platforms.

[agl, 2014-07-18 17:24:56]

BoringSSL LGTM.

[DaleCurtis, 2014-07-18 18:24:06]

lgtm

https://codereview.chromium.org/400233002/diff/1/ash/BUILD.gn
File ash/BUILD.gn (right):

https://codereview.chromium.org/400233002/diff/1/ash/BUILD.gn#newcode106
ash/BUILD.gn:106: sources -= [
It's unfortunate this pattern has already spread.

https://codereview.chromium.org/400233002/diff/1/media/BUILD.gn
File media/BUILD.gn (right):

https://codereview.chromium.org/400233002/diff/1/media/BUILD.gn#newcode77
media/BUILD.gn:77: if (is_win) {
On 2014/07/18 17:23:00, brettw wrote:
> For this, I prefer to unconditionally add configs and then make the config do
> things or not depending on the platform, since it makes it easier to come by
> later and add dependent settings for other platforms.

Acknowledged.

[brettw, 2014-07-22 16:35:32]

Committed patchset #2 manually as r284703.