Issue 40023002: Make dart2js Isolate.spawn work.

Issue 40023002: Make dart2js Isolate.spawn work. (Closed)

Created:
7 years, 2 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 1 month ago

Reviewers:
floitsch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make dart2js Isolate.spawn work. Isolate.spawnUri not addressed yet.

Patch Set 2 : Remove whitespace changes to dart2js_html. #

Total comments: 5

Patch Set 3 : Address comments. #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -111 lines)			Patch
M	sdk/lib/_internal/lib/isolate_helper.dart	View		14 chunks	+49 lines, -65 lines	0 comments	Download
M	sdk/lib/_internal/lib/isolate_patch.dart	View	1 2	3 chunks	+5 lines, -14 lines	0 comments	Download
M	sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/isolate/isolate.dart	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download
M	tests/isolate/illegal_msg_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/isolate/isolate.status	View		6 chunks	+2 lines, -28 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://codereview.chromium.org/40023002/diff/20001/sdk/lib/_internal/lib/isolate_patch.dart File sdk/lib/_internal/lib/isolate_patch.dart (right): https://codereview.chromium.org/40023002/diff/20001/sdk/lib/_internal/lib/isolate_patch.dart#newcode16 sdk/lib/_internal/lib/isolate_patch.dart:16: return new Future<Isolate>.value(new Isolate.fromControlPort(controlPort)); We are in the ...

7 years, 2 months ago (2013-10-24 14:27:10 UTC) #2

Lasse Reichstein Nielsen

7 years, 1 month ago (2013-10-25 10:38:16 UTC) #3

https://codereview.chromium.org/40023002/diff/20001/sdk/lib/_internal/lib/iso...
File sdk/lib/_internal/lib/isolate_patch.dart (right):

https://codereview.chromium.org/40023002/diff/20001/sdk/lib/_internal/lib/iso...
sdk/lib/_internal/lib/isolate_patch.dart:16: return new
Future<Isolate>.value(new Isolate.fromControlPort(controlPort));
Avk, yes. Didn't need it in isolate_helper anyway.

https://codereview.chromium.org/40023002/diff/20001/sdk/lib/_internal/lib/iso...
sdk/lib/_internal/lib/isolate_patch.dart:32: static SendPort _spawnFunction(void
topLevelFunction(), [message]) {
Removed completely. It's not being called.

Expand Messages | Collapse Messages