Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: ui/gfx/linux_font_delegate.h

Issue 400193004: Unify desktop Linux and Chrome OS font rendering params. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: update some comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gfx/linux_font_delegate.h
diff --git a/ui/gfx/linux_font_delegate.h b/ui/gfx/linux_font_delegate.h
index cfb23384308a049f18b8424bb551fee003dbd1fb..04d314380a672148e22abdaa0079c0db15cffd55 100644
--- a/ui/gfx/linux_font_delegate.h
+++ b/ui/gfx/linux_font_delegate.h
@@ -7,12 +7,15 @@
#include <string>
+#include "base/memory/scoped_ptr.h"
#include "ui/gfx/font_render_params.h"
#include "ui/gfx/gfx_export.h"
namespace gfx {
-// Allows a Linux platform specific overriding of font preferences.
+class ScopedPangoFontDescription;
+
+// Allows a Linux platform-specific overriding of font preferences.
class GFX_EXPORT LinuxFontDelegate {
public:
virtual ~LinuxFontDelegate() {}
@@ -29,19 +32,12 @@ class GFX_EXPORT LinuxFontDelegate {
// running with the "--ash" flag.)
static const LinuxFontDelegate* instance();
- // Whether we should antialias our text.
- virtual bool UseAntialiasing() const = 0;
-
- // What sort of text hinting should we apply?
- virtual FontRenderParams::Hinting GetHintingStyle() const = 0;
-
- // What sort of subpixel rendering should we perform.
- virtual FontRenderParams::SubpixelRendering
- GetSubpixelRenderingStyle() const = 0;
+ // Returns the default font rendering settings.
+ virtual FontRenderParams GetDefaultFontRenderParams() const = 0;
- // Returns the Pango description for the default UI font. The format matches
- // that returned by pango_font_description_to_string().
- virtual std::string GetDefaultFontDescription() const = 0;
+ // Returns the Pango description for the default UI font.
+ virtual scoped_ptr<ScopedPangoFontDescription>
Daniel Erat 2014/07/18 17:19:11 (i was concerned that the string that used to be r
msw 2014/07/18 19:14:44 Acknowledged.
+ GetDefaultPangoFontDescription() const = 0;
};
} // namespace gfx

Powered by Google App Engine
This is Rietveld 408576698