Unify desktop Linux and Chrome OS font rendering params.

ui/gfx/font_render_params_linux.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gfx/font_render_params.h"
 
 #include "base/command_line.h"
 #include "base/logging.h"
+#include "ui/gfx/linux_font_delegate.h"
 #include "ui/gfx/switches.h"
 
 #include <fontconfig/fontconfig.h>
 
-#if defined(OS_LINUX) && !defined(OS_CHROMEOS)
-#include "ui/gfx/linux_font_delegate.h"
-#endif
-
 namespace gfx {
 
 namespace {
 
-bool SubpixelPositioningRequested(bool for_web_contents) {
-  return CommandLine::ForCurrentProcess()->HasSwitch(
-      for_web_contents ? switches::kEnableWebkitTextSubpixelPositioning
-                       : switches::kEnableBrowserTextSubpixelPositioning);
-}
-
 // Converts Fontconfig FC_HINT_STYLE to FontRenderParams::Hinting.
 FontRenderParams::Hinting ConvertFontconfigHintStyle(int hint_style) {
   switch (hint_style) {
     case FC_HINT_SLIGHT: return FontRenderParams::HINTING_SLIGHT;
     case FC_HINT_MEDIUM: return FontRenderParams::HINTING_MEDIUM;
     case FC_HINT_FULL:   return FontRenderParams::HINTING_FULL;
     default:             return FontRenderParams::HINTING_NONE;
   }
 }
 
@@ skipping 95 matching lines @@
   loaded_defaults = true;
   return default_params;
 }
 
 FontRenderParams GetCustomFontRenderParams(
     bool for_web_contents,
     const std::vector<std::string>* family_list,
     const int* pixel_size,
     const int* point_size,
     std::string* family_out) {
-  FontRenderParams params;
   if (family_out)
     family_out->clear();
 
-#if defined(OS_CHROMEOS)
-  // Use reasonable defaults.
-  params.antialiasing = true;
-  params.autohinter = true;
-  params.use_bitmaps = true;
-  params.hinting = FontRenderParams::HINTING_SLIGHT;
+  // Start with the delegate's settings, but let Fontconfig have the final say.
+  FontRenderParams params;
+  const LinuxFontDelegate* delegate = LinuxFontDelegate::instance();
+  if (delegate)
+    params = delegate->GetDefaultFontRenderParams();
+  QueryFontconfig(family_list, pixel_size, point_size, &params, family_out);
 
-  // Query Fontconfig to get the family name and subpixel rendering setting.
-  // In general, we try to limit Chrome OS's dependency on Fontconfig, but it's
-  // used to configure fonts for different scripts and to disable subpixel
-  // rendering on systems that use external displays.
-  // TODO(derat): Decide if we should just use Fontconfig wholeheartedly on
-  // Chrome OS; Blink is using it, after all.
-  FontRenderParams fc_params;
-  QueryFontconfig(family_list, pixel_size, point_size, &fc_params, family_out);
-  params.subpixel_rendering = fc_params.subpixel_rendering;
-#else
-  // Start with the delegate's settings, but let Fontconfig have the final say.
-  // TODO(derat): Figure out if we need to query the delegate at all. Does
-  // GtkSettings always get overridden by Fontconfig in GTK apps?
-  const LinuxFontDelegate* delegate = LinuxFontDelegate::instance();
-  if (delegate) {
-    params.antialiasing = delegate->UseAntialiasing();
-    params.hinting = delegate->GetHintingStyle();
-    params.subpixel_rendering = delegate->GetSubpixelRenderingStyle();
-  }
-  QueryFontconfig(family_list, pixel_size, point_size, &params, family_out);
-#endif
-
-  params.subpixel_positioning = SubpixelPositioningRequested(for_web_contents);
+  // Fontconfig doesn't support configuring subpixel positioning; check a flag.
+  params.subpixel_positioning = CommandLine::ForCurrentProcess()->HasSwitch(
+      for_web_contents ?
+      switches::kEnableWebkitTextSubpixelPositioning :
+      switches::kEnableBrowserTextSubpixelPositioning);
 
   // To enable subpixel positioning, we need to disable hinting.
   if (params.subpixel_positioning)
     params.hinting = FontRenderParams::HINTING_NONE;
 
   // Use the first family from the list if Fontconfig didn't suggest a family.
   if (family_out && family_out->empty() &&
       family_list && !family_list->empty())
     *family_out = (*family_list)[0];
 
   return params;
 }
 
 }  // namespace gfx