DevTools: Make target on TimelineRecord nullable

Source/devtools/front_end/timeline/TimelineUIUtilsImpl.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @constructor
  * @extends {WebInspector.TimelineUIUtils}
  */
 WebInspector.TimelineUIUtilsImpl = function()
 {
@@ skipping 75 matching lines @@
      * @return {!WebInspector.TimelineCategory}
      */
     categoryForRecord: function(record)
     {
         return WebInspector.TimelineUIUtilsImpl.recordStyle(record).category;
     },
 
     /**
      * @param {!WebInspector.TimelineModel.Record} record
      * @param {!WebInspector.Linkifier} linkifier
-     * @param {boolean} loadedFromFile
      * @return {?Node}
      */
-    buildDetailsNode: function(record, linkifier, loadedFromFile)
+    buildDetailsNode: function(record, linkifier)
     {
-        return WebInspector.TimelineUIUtilsImpl.buildDetailsNode(record, linkifier, loadedFromFile);
+        return WebInspector.TimelineUIUtilsImpl.buildDetailsNode(record, linkifier);
     },
 
     /**
      * @param {!WebInspector.TimelineModel.Record} record
      * @param {!WebInspector.TimelineModel} model
      * @param {!WebInspector.Linkifier} linkifier
      * @param {function(!DocumentFragment)} callback
-     * @param {boolean} loadedFromFile
      */
-    generateDetailsContent: function(record, model, linkifier, callback, loadedFromFile)
+    generateDetailsContent: function(record, model, linkifier, callback)
     {
-        WebInspector.TimelineUIUtilsImpl.generateDetailsContent(record, model, linkifier, callback, loadedFromFile);
+        WebInspector.TimelineUIUtilsImpl.generateDetailsContent(record, model, linkifier, callback);
     },
 
     /**
      * @return {!Element}
      */
     createBeginFrameDivider: function()
     {
         return this.createEventDivider(WebInspector.TimelineModel.RecordType.BeginFrame);
     },
 
@@ skipping 186 matching lines @@
     var children = record.children();
     for (var i = 0; i < children.length; ++i)
         WebInspector.TimelineUIUtilsImpl.aggregateTimeForRecord(total, children[i]);
     var categoryName = WebInspector.TimelineUIUtilsImpl.recordStyle(record).category.name;
     total[categoryName] = (total[categoryName] || 0) + record.selfTime();
 }
 
 /**
  * @param {!WebInspector.TimelineModel.Record} record
  * @param {!WebInspector.Linkifier} linkifier
- * @param {boolean} loadedFromFile
  * @return {?Node}
  */
-WebInspector.TimelineUIUtilsImpl.buildDetailsNode = function(record, linkifier, loadedFromFile)
+WebInspector.TimelineUIUtilsImpl.buildDetailsNode = function(record, linkifier)
 {
     var details;
     var detailsText;
     var recordData = record.data();
     switch (record.type()) {
     case WebInspector.TimelineModel.RecordType.GCEvent:
         detailsText = WebInspector.UIString("%s collected", Number.bytesToString(recordData["usedHeapSizeDelta"]));
         break;
     case WebInspector.TimelineModel.RecordType.TimerFire:
         detailsText = recordData["timerId"];
@@ skipping 67 matching lines @@
     return details;
 
     /**
      * @param {string} scriptId
      * @param {string} url
      * @param {number} lineNumber
      * @param {number=} columnNumber
      */
     function linkifyLocation(scriptId, url, lineNumber, columnNumber)
     {
-        if (!loadedFromFile && scriptId !== "0") {
-            var location = new WebInspector.DebuggerModel.Location(
-                record.target(),
-                scriptId,
-                lineNumber - 1,
-                (columnNumber || 1) - 1);
-            return linkifier.linkifyRawLocation(location, "timeline-details");
-        }
-
         if (!url)
             return null;
 
         // FIXME(62725): stack trace line/column numbers are one-based.
         columnNumber = columnNumber ? columnNumber - 1 : 0;
-        return linkifier.linkifyLocation(record.target(), url, lineNumber - 1, columnNumber, "timeline-details");
+        return linkifier.linkifyLocationByScriptId(record.target(), scriptId, url, lineNumber - 1, columnNumber, "timeline-details");
     }
 
     /**
      * @param {!ConsoleAgent.CallFrame} callFrame
      */
     function linkifyCallFrame(callFrame)
     {
         return linkifyLocation(callFrame.scriptId, callFrame.url, callFrame.lineNumber, callFrame.columnNumber);
     }
 
@@ skipping 28 matching lines @@
     default:
         return false;
     }
 }
 
 /**
  * @param {!WebInspector.TimelineModel.Record} record
  * @param {!WebInspector.TimelineModel} model
  * @param {!WebInspector.Linkifier} linkifier
  * @param {function(!DocumentFragment)} callback
- * @param {boolean} loadedFromFile
  */
-WebInspector.TimelineUIUtilsImpl.generateDetailsContent = function(record, model, linkifier, callback, loadedFromFile)
+WebInspector.TimelineUIUtilsImpl.generateDetailsContent = function(record, model, linkifier, callback)
 {
     var imageElement = /** @type {?Element} */ (record.getUserObject("TimelineUIUtils::preview-element") || null);
     var relatedNode = null;
     var recordData = record.data();
     var barrier = new CallbackBarrier();
-    if (!imageElement && WebInspector.TimelineUIUtilsImpl._needsPreviewElement(record.type()))
-        WebInspector.DOMPresentationUtils.buildImagePreviewContents(record.target(), recordData["url"], false, barrier.createCallback(saveImage));
-    if (recordData["backendNodeId"])
-        record.target().domModel.pushNodesByBackendIdsToFrontend([recordData["backendNodeId"]], barrier.createCallback(setRelatedNode));
+    var target = record.target();
+    if (!imageElement && WebInspector.TimelineUIUtilsImpl._needsPreviewElement(record.type()) && target)
+        WebInspector.DOMPresentationUtils.buildImagePreviewContents(target, recordData["url"], false, barrier.createCallback(saveImage));
+    if (recordData["backendNodeId"] && target)
+        target.domModel.pushNodesByBackendIdsToFrontend([recordData["backendNodeId"]], barrier.createCallback(setRelatedNode));
     barrier.callWhenDone(callbackWrapper);
 
     /**
      * @param {!Element=} element
      */
     function saveImage(element)
     {
         imageElement = element || null;
         record.setUserObject("TimelineUIUtils::preview-element", element);
     }
 
     /**
      * @param {?Array.<!DOMAgent.NodeId>} nodeIds
      */
     function setRelatedNode(nodeIds)
     {
-        if (nodeIds)
-            relatedNode = record.target().domModel.nodeForId(nodeIds[0]);
+        if (nodeIds && target)
+            relatedNode = target.domModel.nodeForId(nodeIds[0]);
     }
 
     function callbackWrapper()
     {
-        callback(WebInspector.TimelineUIUtilsImpl._generateDetailsContentSynchronously(record, model, linkifier, imageElement, relatedNode, loadedFromFile));
+        callback(WebInspector.TimelineUIUtilsImpl._generateDetailsContentSynchronously(record, model, linkifier, imageElement, relatedNode));
     }
 }
 
 /**
  * @param {!WebInspector.TimelineModel.Record} record
  * @param {!WebInspector.TimelineModel} model
  * @param {!WebInspector.Linkifier} linkifier
  * @param {?Element} imagePreviewElement
  * @param {?WebInspector.DOMNode} relatedNode
- * @param {boolean} loadedFromFile
  * @return {!DocumentFragment}
  */
-WebInspector.TimelineUIUtilsImpl._generateDetailsContentSynchronously = function(record, model, linkifier, imagePreviewElement, relatedNode, loadedFromFile)
+WebInspector.TimelineUIUtilsImpl._generateDetailsContentSynchronously = function(record, model, linkifier, imagePreviewElement, relatedNode)
 {
     var fragment = document.createDocumentFragment();
     var aggregatedStats = {};
     WebInspector.TimelineUIUtilsImpl.aggregateTimeForRecord(aggregatedStats, record);
     if (record.children().length)
         fragment.appendChild(WebInspector.TimelineUIUtils.generatePieChart(aggregatedStats, WebInspector.TimelineUIUtilsImpl.recordStyle(record).category, record.selfTime()));
     else
         fragment.appendChild(WebInspector.TimelineUIUtils.generatePieChart(aggregatedStats));
 
     const recordTypes = WebInspector.TimelineModel.RecordType;
@@ skipping 109 matching lines @@
                 contentHelper.appendTextRow(WebInspector.UIString("URL"), initiatorData["webSocketURL"]);
             if (typeof initiatorData["webSocketProtocol"] !== "undefined")
                 contentHelper.appendTextRow(WebInspector.UIString("WebSocket Protocol"), initiatorData["webSocketProtocol"]);
             if (typeof recordData["message"] !== "undefined")
                 contentHelper.appendTextRow(WebInspector.UIString("Message"), recordData["message"]);
             break;
         case recordTypes.EmbedderCallback:
             contentHelper.appendTextRow(WebInspector.UIString("Callback Function"), recordData["callbackName"]);
             break;
         default:
-            var detailsNode = WebInspector.TimelineUIUtilsImpl.buildDetailsNode(record, linkifier, loadedFromFile);
+            var detailsNode = WebInspector.TimelineUIUtilsImpl.buildDetailsNode(record, linkifier);
             if (detailsNode)
                 contentHelper.appendElementRow(WebInspector.UIString("Details"), detailsNode);
             break;
     }
 
     if (relatedNode)
         contentHelper.appendElementRow(relatedNodeLabel || WebInspector.UIString("Related node"), WebInspector.DOMPresentationUtils.linkifyNodeReference(relatedNode));
 
     if (recordData["scriptName"] && record.type() !== recordTypes.FunctionCall)
         contentHelper.appendLocationRow(WebInspector.UIString("Function Call"), recordData["scriptName"], recordData["scriptLine"]);
@@ skipping 34 matching lines @@
     else if (recordType === recordTypes.TimeStamp)
         eventDivider.className += " resources-orange-divider";
     else if (recordType === recordTypes.BeginFrame)
         eventDivider.className += " timeline-frame-divider";
 
     if (title)
         eventDivider.title = title;
 
     return eventDivider;
 }