Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Side by Side Diff: Source/devtools/front_end/timeline/TimelineUIUtils.js

Issue 400143002: DevTools: Make target on TimelineRecord nullable (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase on master Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * Copyright (C) 2012 Intel Inc. All rights reserved. 3 * Copyright (C) 2012 Intel Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 * @param {!WebInspector.TimelineModel.Record} record 95 * @param {!WebInspector.TimelineModel.Record} record
96 * @return {!WebInspector.TimelineCategory} 96 * @return {!WebInspector.TimelineCategory}
97 */ 97 */
98 categoryForRecord: function(record) 98 categoryForRecord: function(record)
99 { 99 {
100 throw new Error("Not implemented."); 100 throw new Error("Not implemented.");
101 }, 101 },
102 /** 102 /**
103 * @param {!WebInspector.TimelineModel.Record} record 103 * @param {!WebInspector.TimelineModel.Record} record
104 * @param {!WebInspector.Linkifier} linkifier 104 * @param {!WebInspector.Linkifier} linkifier
105 * @param {boolean} loadedFromFile
106 * @return {?Node} 105 * @return {?Node}
107 */ 106 */
108 buildDetailsNode: function(record, linkifier, loadedFromFile) 107 buildDetailsNode: function(record, linkifier)
109 { 108 {
110 throw new Error("Not implemented."); 109 throw new Error("Not implemented.");
111 }, 110 },
112 /** 111 /**
113 * @param {!WebInspector.TimelineModel.Record} record 112 * @param {!WebInspector.TimelineModel.Record} record
114 * @param {!WebInspector.TimelineModel} model 113 * @param {!WebInspector.TimelineModel} model
115 * @param {!WebInspector.Linkifier} linkifier 114 * @param {!WebInspector.Linkifier} linkifier
116 * @param {function(!DocumentFragment)} callback 115 * @param {function(!DocumentFragment)} callback
117 * @param {boolean} loadedFromFile
118 */ 116 */
119 generateDetailsContent: function(record, model, linkifier, callback, loadedF romFile) 117 generateDetailsContent: function(record, model, linkifier, callback)
120 { 118 {
121 throw new Error("Not implemented."); 119 throw new Error("Not implemented.");
122 }, 120 },
123 /** 121 /**
124 * @return {!Element} 122 * @return {!Element}
125 */ 123 */
126 createBeginFrameDivider: function() 124 createBeginFrameDivider: function()
127 { 125 {
128 throw new Error("Not implemented."); 126 throw new Error("Not implemented.");
129 }, 127 },
(...skipping 439 matching lines...) Expand 10 before | Expand all | Expand 10 after
569 for (var i = 0; i < stackTrace.length; ++i) { 567 for (var i = 0; i < stackTrace.length; ++i) {
570 var stackFrame = stackTrace[i]; 568 var stackFrame = stackTrace[i];
571 var row = stackTraceElement.createChild("div"); 569 var row = stackTraceElement.createChild("div");
572 row.createTextChild(stackFrame.functionName || WebInspector.UIString ("(anonymous function)")); 570 row.createTextChild(stackFrame.functionName || WebInspector.UIString ("(anonymous function)"));
573 row.createTextChild(" @ "); 571 row.createTextChild(" @ ");
574 var urlElement = this._linkifier.linkifyLocationByScriptId(this._tar get, stackFrame.scriptId, stackFrame.url, stackFrame.lineNumber - 1, stackFrame. columnNumber - 1); 572 var urlElement = this._linkifier.linkifyLocationByScriptId(this._tar get, stackFrame.scriptId, stackFrame.url, stackFrame.lineNumber - 1, stackFrame. columnNumber - 1);
575 row.appendChild(urlElement); 573 row.appendChild(urlElement);
576 } 574 }
577 } 575 }
578 } 576 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/timeline/TimelinePanel.js ('k') | Source/devtools/front_end/timeline/TimelineUIUtilsImpl.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698