Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 400143002: DevTools: Make target on TimelineRecord nullable (Closed)

Created:
6 years, 5 months ago by sergeyv
Modified:
6 years, 5 months ago
Reviewers:
caseq, yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Make target on TimelineRecord nullable BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178473

Patch Set 1 #

Patch Set 2 : Rebase on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -66 lines) Patch
M Source/devtools/front_end/timeline/TimelineModel.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TimelineModelImpl.js View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineUIUtils.js View 1 2 chunks +2 lines, -4 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineUIUtilsImpl.js View 1 8 chunks +17 lines, -30 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineView.js View 2 chunks +10 lines, -7 lines 0 comments Download
M Source/devtools/front_end/timeline/TracingTimelineModel.js View 1 1 chunk +2 lines, -3 lines 0 comments Download
M Source/devtools/front_end/timeline/TracingTimelineUIUtils.js View 1 6 chunks +9 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sergeyv
6 years, 5 months ago (2014-07-18 08:42:22 UTC) #1
yurys
lgtm
6 years, 5 months ago (2014-07-18 09:04:34 UTC) #2
sergeyv
The CQ bit was checked by sergeyv@chromium.org
6 years, 5 months ago (2014-07-18 18:09:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/400143002/20001
6 years, 5 months ago (2014-07-18 18:10:21 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 19:13:45 UTC) #5
Message was sent while issue was closed.
Change committed as 178473

Powered by Google App Engine
This is Rietveld 408576698