Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Issue 400093002: Remove jingle_glue_test_util target (Closed)

Created:
6 years, 5 months ago by Sergey Ulanov
Modified:
6 years, 5 months ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

Remove jingle_glue_test_util target jingle_glue_test_util was added long time ago for P2P API in Pepper. The API was removed long time ago and we no longer need jingle_glue_test_util. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284514

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -432 lines) Patch
M content/content_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D jingle/glue/fake_network_manager.h View 1 chunk +0 lines, -41 lines 0 comments Download
D jingle/glue/fake_network_manager.cc View 1 chunk +0 lines, -51 lines 0 comments Download
D jingle/glue/fake_socket_factory.h View 1 chunk +0 lines, -125 lines 0 comments Download
D jingle/glue/fake_socket_factory.cc View 1 chunk +0 lines, -199 lines 0 comments Download
M jingle/jingle.gyp View 2 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Sergey Ulanov
6 years, 5 months ago (2014-07-17 23:36:32 UTC) #1
Alpha Left Google
lgtm
6 years, 5 months ago (2014-07-18 00:36:30 UTC) #2
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 5 months ago (2014-07-21 17:29:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/400093002/20001
6 years, 5 months ago (2014-07-21 17:29:38 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-21 21:57:52 UTC) #5
Message was sent while issue was closed.
Change committed as 284514

Powered by Google App Engine
This is Rietveld 408576698