Fix garbled text when loading linearized pdf document

Fix garbled text when loading linearized pdf document

BUG=260112, 249006, 275281, 354966, 365302, 236952
R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/a9c29e0

[Bo Xu, 2014-07-17 23:00:51]

Please review and verify the fix. Thanks.

[Lei Zhang, 2014-07-17 23:05:19]

Nice. This bug has been widely reported and I'm glad to see a fix. I'll try to
repro it again and see if I can verify this fix works.

https://codereview.chromium.org/400083002/diff/1/core/src/fpdfapi/fpdf_parser...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp (right):

https://codereview.chromium.org/400083002/diff/1/core/src/fpdfapi/fpdf_parser...
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp:1653:
FXSYS_qsort(m_SortedOffset.GetData(), m_SortedOffset.GetSize(),
sizeof(FX_FILESIZE), _CompareDWord);
Wouldn't you want _CompareDWord() to be _CompareFileSize() ?

[Bo Xu, 2014-07-17 23:13:17]

https://codereview.chromium.org/400083002/diff/1/core/src/fpdfapi/fpdf_parser...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp (right):

https://codereview.chromium.org/400083002/diff/1/core/src/fpdfapi/fpdf_parser...
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp:1653:
FXSYS_qsort(m_SortedOffset.GetData(), m_SortedOffset.GetSize(),
sizeof(FX_FILESIZE), _CompareDWord);
On 2014/07/17 23:05:19, Lei Zhang wrote:
> Wouldn't you want _CompareDWord() to be _CompareFileSize() ?
That's right! Change made.

[Lei Zhang, 2014-07-17 23:16:15]

lgtm with comment below. If you are confident in the fix, then don't wait for me
to verify the fix.

https://codereview.chromium.org/400083002/diff/20001/core/src/fpdfapi/fpdf_pa...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp (right):

https://codereview.chromium.org/400083002/diff/20001/core/src/fpdfapi/fpdf_pa...
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp:29: static FX_INT32
_CompareDWord(const void* p1, const void* p2)
Now _CompareDword() is no longer used.

[Lei Zhang, 2014-07-18 00:34:58]

Seems to fix the problem for me.

[Bo Xu, 2014-07-18 02:15:41]

Committed patchset #2 manually as ra9c29e0 (presubmit successful).