Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 400073003: Finish decoupling sync and invalidations (Closed)

Created:
6 years, 5 months ago by rlarocque
Modified:
6 years, 5 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, davemoore+watch_chromium.org, extensions-reviews_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, tim+watch_chromium.org, zea+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Finish decoupling sync and invalidations Moves the remaining invalidations code from sync/internal_api/public/base/ to components/invalidation/. TBR=atwilson BUG=259559 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285102

Patch Set 1 #

Patch Set 2 : Add missing files #

Patch Set 3 : Fix sync_tools #

Patch Set 4 : Export another symbol for sync_tools #

Patch Set 5 : Rebase #

Patch Set 6 : Fix GN #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -1029 lines) Patch
M chrome/browser/chromeos/policy/DEPS View 1 2 3 4 5 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_invalidator.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_cloud_policy_invalidator_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/push_messaging/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/push_messaging/push_messaging_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/push_messaging/push_messaging_invalidation_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/invalidation/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/invalidation/invalidation_controller_android.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/DEPS View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_browsertest.cc View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_invalidator.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_invalidator_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/invalidation_adapter.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/invalidation_helper.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_core.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_android.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/fake_server_invalidation_service.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/invalidations_message_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M components/invalidation.gypi View 1 2 3 4 5 3 chunks +12 lines, -0 lines 0 comments Download
M components/invalidation/BUILD.gn View 1 2 3 4 5 3 chunks +12 lines, -0 lines 0 comments Download
M components/invalidation/DEPS View 1 chunk +3 lines, -5 lines 0 comments Download
A + components/invalidation/ack_handle.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + components/invalidation/ack_handle.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/invalidation/ack_handler.h View 2 chunks +9 lines, -11 lines 0 comments Download
A + components/invalidation/ack_handler.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M components/invalidation/fake_invalidator.h View 1 chunk +1 line, -1 line 0 comments Download
A + components/invalidation/invalidation.h View 1 2 3 4 5 3 chunks +9 lines, -10 lines 0 comments Download
A + components/invalidation/invalidation.cc View 1 2 3 4 5 7 chunks +29 lines, -37 lines 0 comments Download
M components/invalidation/invalidation_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M components/invalidation/invalidation_logger.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/invalidation/invalidation_logger_observer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/invalidation/invalidation_notifier.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/invalidation/invalidation_notifier_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/invalidation/invalidation_service.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/invalidation/invalidation_service_test_template.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/invalidation/invalidation_state_tracker.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/invalidation/invalidation_test_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/invalidation/invalidation_test_util.cc View 6 chunks +11 lines, -12 lines 0 comments Download
A + components/invalidation/invalidation_util.h View 1 2 3 4 5 2 chunks +7 lines, -9 lines 0 comments Download
A + components/invalidation/invalidation_util.cc View 1 2 3 4 5 4 chunks +6 lines, -9 lines 0 comments Download
M components/invalidation/invalidator.h View 1 chunk +2 lines, -3 lines 0 comments Download
M components/invalidation/invalidator_registrar.h View 1 chunk +1 line, -1 line 0 comments Download
A + components/invalidation/invalidator_state.h View 2 chunks +6 lines, -5 lines 0 comments Download
A + components/invalidation/invalidator_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/invalidation/mock_ack_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/invalidation/mock_ack_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/invalidation/non_blocking_invalidator.h View 1 chunk +1 line, -1 line 0 comments Download
M components/invalidation/notifier_reason_util.h View 1 chunk +1 line, -1 line 0 comments Download
M components/invalidation/object_id_invalidation_map.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/invalidation/object_id_invalidation_map_test_util.h View 1 chunk +1 line, -1 line 0 comments Download
M components/invalidation/object_id_invalidation_map_test_util.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M components/invalidation/p2p_invalidator.h View 1 chunk +1 line, -2 lines 0 comments Download
M components/invalidation/p2p_invalidator.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/invalidation/p2p_invalidator_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M components/invalidation/registration_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M components/invalidation/registration_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/invalidation/registration_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/invalidation/single_object_invalidation_set.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/invalidation/single_object_invalidation_set.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/invalidation/single_object_invalidation_set_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/invalidation/sync_invalidation_listener.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/invalidation/sync_invalidation_listener.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/invalidation/sync_invalidation_listener_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M components/invalidation/sync_system_resources.h View 1 chunk +1 line, -1 line 0 comments Download
M components/invalidation/sync_system_resources.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/invalidation/ticl_invalidation_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/invalidation/unacked_invalidation_set.h View 1 chunk +3 lines, -3 lines 0 comments Download
M components/invalidation/unacked_invalidation_set.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/public/base/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D sync/internal_api/public/base/ack_handle.h View 1 chunk +0 lines, -47 lines 0 comments Download
D sync/internal_api/public/base/ack_handle.cc View 1 chunk +0 lines, -67 lines 0 comments Download
D sync/internal_api/public/base/ack_handler.h View 1 chunk +0 lines, -42 lines 0 comments Download
D sync/internal_api/public/base/ack_handler.cc View 1 chunk +0 lines, -15 lines 0 comments Download
D sync/internal_api/public/base/invalidation.h View 1 2 3 4 5 1 chunk +0 lines, -122 lines 0 comments Download
D sync/internal_api/public/base/invalidation.cc View 1 2 3 4 5 1 chunk +0 lines, -178 lines 0 comments Download
D sync/internal_api/public/base/invalidation_test_util.h View 1 chunk +0 lines, -26 lines 0 comments Download
D sync/internal_api/public/base/invalidation_test_util.cc View 1 chunk +0 lines, -121 lines 0 comments Download
D sync/internal_api/public/base/invalidation_util.h View 1 2 3 4 5 1 chunk +0 lines, -59 lines 0 comments Download
D sync/internal_api/public/base/invalidation_util.cc View 1 2 3 4 5 1 chunk +0 lines, -73 lines 0 comments Download
D sync/internal_api/public/base/invalidator_state.h View 1 chunk +0 lines, -30 lines 0 comments Download
D sync/internal_api/public/base/invalidator_state.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M sync/sync_internal_api.gypi View 1 2 3 4 5 3 chunks +0 lines, -15 lines 0 comments Download
M sync/sync_tests.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M sync/tools/invalidation_helper.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M sync/tools/null_invalidation_state_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/tools/sync_listen_notifications.cc View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
rlarocque
This should be the last big CL required to separate the build of sync and ...
6 years, 5 months ago (2014-07-23 17:43:41 UTC) #1
dcheng
Nice! chrome/browser/extensions/api/push_messaging LGTM
6 years, 5 months ago (2014-07-23 17:51:58 UTC) #2
James Hawkins
webui lgtm
6 years, 5 months ago (2014-07-23 19:43:22 UTC) #3
pavely
lgtm
6 years, 5 months ago (2014-07-23 21:39:58 UTC) #4
rlarocque
Thanks for the reviews. That was faster than expected. I'm going to TBR the policy ...
6 years, 5 months ago (2014-07-23 21:50:08 UTC) #5
rlarocque
The CQ bit was checked by rlarocque@chromium.org
6 years, 5 months ago (2014-07-23 21:50:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/400073003/100001
6 years, 5 months ago (2014-07-23 21:54:14 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 01:13:55 UTC) #8
Message was sent while issue was closed.
Change committed as 285102

Powered by Google App Engine
This is Rietveld 408576698