Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(979)

Issue 40006: Fix error being thrown in isInNet() PAC js (Closed)

Created:
11 years, 9 months ago by eroman
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix error being thrown in isInNet() PAC js. Mozilla is using notation which treats regexp like a function: var regex = /foo/; var result = regex("str"); However v8 does not allow this (nor does IE), so we rewrite it in standard form: var regex = /foo/; var result = regex.exec("str") Also finishes off the tests in pac_library_unittest.js. I didn't test every single permutation of dateRange() and timeRange() as there are way too many; but did hit most common flavors. BUG=2764 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10843

Patch Set 1 #

Patch Set 2 : use exec() and add a test for bad ip address #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -20 lines) Patch
M net/data/proxy_resolver_v8_unittest/pac_library_unittest.js View 1 3 chunks +173 lines, -19 lines 0 comments Download
M net/proxy/proxy_resolver_script.h View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
eroman
11 years, 9 months ago (2009-03-03 10:52:03 UTC) #1
darin (slow to review)
LGTM is this a v8 bug then?
11 years, 9 months ago (2009-03-03 22:00:18 UTC) #2
eroman
IE doesn't support this either, so probably not a big compat issue. I will file ...
11 years, 9 months ago (2009-03-03 22:32:35 UTC) #3
darin (slow to review)
11 years, 9 months ago (2009-03-03 22:46:11 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698