Chromium Code Reviews
DescriptionFix error being thrown in isInNet() PAC js.
Mozilla is using notation which treats regexp like a function:
var regex = /foo/;
var result = regex("str");
However v8 does not allow this (nor does IE), so we rewrite it in standard form:
var regex = /foo/;
var result = regex.exec("str")
Also finishes off the tests in pac_library_unittest.js. I didn't test every single permutation of dateRange() and timeRange() as there are way too many; but did hit most common flavors.
BUG=2764
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10843
Patch Set 1 #Patch Set 2 : use exec() and add a test for bad ip address #
Messages
Total messages: 4 (0 generated)
|
||||||||||||||||||||||||||||