Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 400043004: InterfacePtr: not configure proxy until actual read/write is needed. (Closed)

Created:
6 years, 5 months ago by yzshen1
Modified:
6 years, 5 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

InterfacePtr: not setup proxy until actual read/write is needed. A common usage of InterfacePtr is: (1) Create a new InterfacePtr instance. (2) BindToProxy() is called to bind the interface pointer to an implementation. (3) Immediately, the message pipe handle underneath the interface pointer is detached and sent over another message pipe. In step (2), currently we do all the setup work for the interface pointer: construct Router and Connector instance, post task to start watching the message pipe handle, etc. All the work is thrown away at step (3). With this CL, the proxy setup work won't be done until actual read/write is needed. BUG=394883 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284034

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -34 lines) Patch
M mojo/apps/js/test/js_to_cpp_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/interface_ptr.h View 1 4 chunks +11 lines, -14 lines 0 comments Download
M mojo/public/cpp/bindings/lib/interface_ptr_internal.h View 1 4 chunks +75 lines, -17 lines 0 comments Download
M mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/validation_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
yzshen1
Hi, Darin. Would you please take a look? Thanks!
6 years, 5 months ago (2014-07-17 23:06:20 UTC) #1
darin (slow to review)
LGTM I'm on the fence about the renaming of router() to router_for_testing(). It is hidden ...
6 years, 5 months ago (2014-07-18 03:44:45 UTC) #2
yzshen1
Thanks Darin!
6 years, 5 months ago (2014-07-18 06:34:47 UTC) #3
yzshen1
The CQ bit was checked by yzshen@chromium.org
6 years, 5 months ago (2014-07-18 06:34:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/400043004/20001
6 years, 5 months ago (2014-07-18 06:36:00 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 08:30:12 UTC) #6
Message was sent while issue was closed.
Change committed as 284034

Powered by Google App Engine
This is Rietveld 408576698