Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Unified Diff: gyp/common_conditions.gypi

Issue 400043003: Run CanvasState test across a library boundary. (Closed) Base URL: https://skia.googlesource.com/skia.git@canvasState2
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gyp/canvas_state_lib.gyp ('k') | gyp/most.gyp » ('j') | gyp/most.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gyp/common_conditions.gypi
diff --git a/gyp/common_conditions.gypi b/gyp/common_conditions.gypi
index 4bbacec1e9997f36bd814f5ccb94c3bd73e6d945..19a4287877caf45e332ce0b730138fd86a5e1d1f 100644
--- a/gyp/common_conditions.gypi
+++ b/gyp/common_conditions.gypi
@@ -186,6 +186,8 @@
'-Wpointer-arith',
'-Wno-unused-parameter',
+ # For now. Perhaps I should do what mtklein suggested and add skia_pic
djsollen 2014/07/18 14:11:54 that seems like a good idea with a default to true
scroggo 2014/07/18 19:31:01 Uploaded a separate CL for that: https://coderevie
+ '-fPIC',
],
'cflags_cc': [
'-fno-rtti',
« no previous file with comments | « gyp/canvas_state_lib.gyp ('k') | gyp/most.gyp » ('j') | gyp/most.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698