gyp/canvas_state_lib.gyp - Issue 400043003: Run CanvasState test across a library boundary.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: gyp/canvas_state_lib.gyp

Issue 400043003: Run CanvasState test across a library boundary. (Closed) Base URL: https://skia.googlesource.com/skia.git@canvasState2

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Building test for running CanvasState

	2

	3 {

	4 'targets' : [

	5 {

	6 'target_name' : 'canvas_state_lib',

	7 'type' : 'shared_library',

	8 # FIXME: Is there a way to ensure that -fPIC was used for skia_lib?

	9 'dependencies' : [ 'skia_lib.gyp:skia_lib'],

	10 'sources' : [

	11 '../tests/CanvasStateHelpers.cpp',

	12 ],

	13 'cflags' : [

	14 '-fPIC',

	15 ],

	16 },

	17 {

	18 # Dummy 'most' target, since gyp_skia sets 'most' to be the default.
	djsollen 2014/07/22 15:06:34 Can you remove this as well? How does canvas_stat Can you remove this as well? How does canvas_state_lib get picked up in a normal build? Shouldn't it be part of most.gyp, perhaps just for Android? scroggo 2014/07/22 17:10:10 Currently, it does not. In order to build it, you Show quoted text On 2014/07/22 15:06:34, djsollen wrote: > Can you remove this as well? > > How does canvas_state_lib get picked up in a normal build? Currently, it does not. In order to build it, you use: GYP_DEFINES=skia_pic=1 ./gyp_skia gyp/canvas_state_lib.gyp && ninja -C out/Debug canvas_state_lib (Which I need to document somewhere if we leave the current behavior.) Show quoted text > Shouldn't it be part > of most.gyp, perhaps just for Android? Possibly. I'm not sure though. It won't actually be used with the rest of the build (it's intended to run with a different version of Skia, after all), so I'm not sure it makes sense to build it with the rest of the build. (Also it's nice to be able to run the test on platforms other than Android. In that case, it would need to be included as part of most no matter what. That leaves the problem that it won't build unless you use skia_pic, which is not the default on all platforms.) scroggo 2014/07/22 18:12:01 Done. Show quoted text On 2014/07/22 17:10:10, scroggo wrote: > In order to build it, you use: > > GYP_DEFINES=skia_pic=1 ./gyp_skia gyp/canvas_state_lib.gyp && ninja -C out/Debug > canvas_state_lib > > (Which I need to document somewhere if we leave the current behavior.) Done.
	19 'target_name' : 'most',

	20 'type' : 'none',

	21 'dependencies' : [

	22 'canvas_state_lib',

	23 ],

	24 }

	25 ],

	26 }

OLD	NEW

« no previous file with comments | « no previous file | gyp/common_conditions.gypi » ('j') | gyp/common_conditions.gypi » ('J')