Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 400043002: Add a way to schedule generic per-frame events through Document. (Closed)

Created:
6 years, 5 months ago by cbiesinger
Modified:
6 years, 4 months ago
Reviewers:
haraken, esprehn
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Project:
blink
Visibility:
Public.

Description

Add a way to schedule generic per-frame events through Document. Currently, there is no way to call ScriptedAnimationController::enqueuePerFrameEvent through Document, there's only enqueueAnimationFrameEvent() which does not ensure uniqueness, and special-case functions which do guarantee uniqueness for special events like resize. This will be for https://codereview.chromium.org/396283004/ BUG=375658

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M Source/core/dom/Document.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/Document.cpp View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
cbiesinger
6 years, 5 months ago (2014-07-17 19:39:08 UTC) #1
haraken
As commented in https://codereview.chromium.org/396283004/#msg9, let's split a CL into pieces so that each piece is ...
6 years, 5 months ago (2014-07-18 01:17:25 UTC) #2
esprehn
On 2014/07/18 at 01:17:25, haraken wrote: > As commented in https://codereview.chromium.org/396283004/#msg9, let's split a CL ...
6 years, 4 months ago (2014-08-01 14:10:01 UTC) #3
haraken
6 years, 4 months ago (2014-08-01 14:11:24 UTC) #4
On 2014/08/01 14:10:01, esprehn wrote:
> On 2014/07/18 at 01:17:25, haraken wrote:
> > As commented in https://codereview.chromium.org/396283004/#msg9, let's split
a
> CL into pieces so that each piece is actually used and has a test case.
> 
> What's the current progress of this?

We decided to not split the CL since a meaningful split is not easy. Waiting for
your comment on https://codereview.chromium.org/396283004/.

Powered by Google App Engine
This is Rietveld 408576698