Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(905)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 400033002: update pathops core and tests (Closed)

Created:
6 years, 5 months ago by caryclark
Modified:
6 years, 5 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

update pathops core and tests split out skpclip (the test of 1M pictures) into its own project TBR=reed Committed: https://skia.googlesource.com/skia/+/19eb3b2f0aa6dce5c0335230a8930e90733e5d5d

Patch Set 1 #

Patch Set 2 : turn off failing tests #

Patch Set 3 : add space for c++11 #

Patch Set 4 : fix uninitialized variable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1199 lines, -828 lines) Patch
M gyp/most.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A + gyp/pathops_skpclip.gyp View 1 chunk +16 lines, -10 lines 0 comments Download
M gyp/pathops_unittest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M src/pathops/SkDLineIntersection.cpp View 1 chunk +17 lines, -14 lines 0 comments Download
M src/pathops/SkOpSegment.cpp View 1 2 3 7 chunks +54 lines, -24 lines 0 comments Download
M src/pathops/SkPathOpsDebug.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/pathops/SkPathOpsDebug.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M tests/PathOpsDebug.cpp View 2 chunks +132 lines, -0 lines 0 comments Download
M tests/PathOpsExtendedTest.cpp View 5 chunks +7 lines, -136 lines 0 comments Download
M tests/PathOpsLineIntersectionTest.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/PathOpsOpTest.cpp View 1 1 chunk +26 lines, -0 lines 0 comments Download
M tests/PathOpsSimplifyTest.cpp View 1 chunk +11 lines, -0 lines 0 comments Download
M tests/PathOpsSkpClipTest.cpp View 1 2 18 chunks +563 lines, -563 lines 0 comments Download
M tests/PathOpsSkpTest.cpp View 1 2 chunks +226 lines, -0 lines 0 comments Download
M tools/pathops_sorter.htm View 1 chunk +6 lines, -0 lines 0 comments Download
M tools/pathops_visualizer.htm View 2 chunks +134 lines, -80 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
caryclark
The CQ bit was checked by caryclark@google.com
6 years, 5 months ago (2014-07-17 19:48:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/caryclark@google.com/400033002/20001
6 years, 5 months ago (2014-07-17 19:49:14 UTC) #2
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on tryserver.skia ...
6 years, 5 months ago (2014-07-17 20:00:33 UTC) #3
caryclark
The CQ bit was checked by caryclark@google.com
6 years, 5 months ago (2014-07-17 20:08:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/caryclark@google.com/400033002/40001
6 years, 5 months ago (2014-07-17 20:08:23 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot on tryserver.skia ...
6 years, 5 months ago (2014-07-17 20:20:05 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-17 20:24:05 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot on tryserver.skia (http://108.170.220.76:10117/builders/Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot/builds/3332)
6 years, 5 months ago (2014-07-17 20:24:06 UTC) #8
caryclark
The CQ bit was checked by caryclark@google.com
6 years, 5 months ago (2014-07-18 11:54:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/caryclark@google.com/400033002/60001
6 years, 5 months ago (2014-07-18 11:54:51 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 12:08:24 UTC) #11
Message was sent while issue was closed. 
Change committed as 19eb3b2f0aa6dce5c0335230a8930e90733e5d5d

Powered by Google App Engine
This is Rietveld 408576698