Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 40003002: Add support for tracking NotExectuted/ExecutedOnceCodeAge's when --track_gc_object_stats flag is se… (Closed)

Created:
7 years, 2 months ago by rmcilroy
Modified:
7 years, 1 month ago
CC:
v8-dev
Visibility:
Public.

Description

Add support for tracking NotExectuted/ExecutedOnceCodeAge's when --track_gc_object_stats flag is set. BUG=None R=mstarzinger@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=17513

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Total comments: 2

Patch Set 8 : Fix nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -31 lines) Patch
M src/builtins.h View 2 5 1 chunk +3 lines, -1 line 0 comments Download
M src/heap.h View 1 2 3 4 5 6 7 2 chunks +12 lines, -7 lines 0 comments Download
M src/heap.cc View 1 2 3 4 5 6 7 1 chunk +11 lines, -10 lines 0 comments Download
M src/mark-compact.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 2 3 4 5 6 7 2 chunks +5 lines, -1 line 0 comments Download
M src/objects.cc View 1 2 3 4 5 6 7 4 chunks +22 lines, -7 lines 0 comments Download
M src/v8-counters.h View 2 5 3 chunks +3 lines, -3 lines 0 comments Download
M src/v8-counters.cc View 2 5 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
rmcilroy
PTAL.
7 years, 2 months ago (2013-10-24 12:24:09 UTC) #1
rmcilroy
On 2013/10/24 12:24:09, rmcilroy wrote: > PTAL. Sorry, please ignore patch set 5, I accidentally ...
7 years, 2 months ago (2013-10-24 13:34:29 UTC) #2
rmcilroy
Michael: could you have a look please, I didn't realize Hannes was OOO.
7 years, 1 month ago (2013-11-04 11:05:25 UTC) #3
Michael Starzinger
LGTM. https://codereview.chromium.org/40003002/diff/160001/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/40003002/diff/160001/src/objects.cc#newcode10626 src/objects.cc:10626: } else if (age == Code::kExecutedOnceCodeAge) { nit: ...
7 years, 1 month ago (2013-11-04 12:28:28 UTC) #4
rmcilroy
Thanks Michael! Could you please land for me when you get a chance? https://codereview.chromium.org/40003002/diff/160001/src/objects.cc File ...
7 years, 1 month ago (2013-11-05 13:44:57 UTC) #5
Michael Starzinger
Sure. Will land it now-ish.
7 years, 1 month ago (2013-11-05 14:17:15 UTC) #6
Michael Starzinger
7 years, 1 month ago (2013-11-06 09:29:19 UTC) #7
Message was sent while issue was closed.
Committed patchset #8 manually as r17513.

Powered by Google App Engine
This is Rietveld 408576698