Issue 400013003: Prevent focus from leaving Print Preview overlay controls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 400013003: Prevent focus from leaving Print Preview overlay controls. (Closed)

Created:
6 years, 5 months ago by Aleksey Shlyapnikov

Modified:
6 years, 5 months ago

Reviewers:
Vitaly Buka (NO REVIEWS)

CC:
chromium-reviews, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Prevent focus from leaving Print Preview overlay controls. BUG=276784 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284265

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -0 lines)			Patch
M	chrome/browser/resources/print_preview/print_preview.html	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/resources/print_preview/print_preview.js	View	2 chunks	+2 lines, -0 lines	0 comments	Download
A	chrome/browser/resources/print_preview/print_preview_focus_manager.js	View	1 chunk	+32 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

Aleksey Shlyapnikov

The CQ bit was checked by alekseys@chromium.org

6 years, 5 months ago (2014-07-18 20:20:06 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alekseys@chromium.org/400013003/1

6 years, 5 months ago (2014-07-18 20:21:43 UTC) #4

Message was sent while issue was closed.

Change committed as 284265