Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: chrome/browser/cocoa/browser_window_cocoa.h

Issue 400012: Refactor the keyboard events handling code related to RenderViewHostDelegate:... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/main_menu.h ('k') | chrome/browser/cocoa/browser_window_cocoa.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/browser_window_cocoa.h
===================================================================
--- chrome/browser/cocoa/browser_window_cocoa.h (revision 34219)
+++ chrome/browser/cocoa/browser_window_cocoa.h (working copy)
@@ -91,7 +91,9 @@
bool show_history);
virtual void ShowPageMenu();
virtual void ShowAppMenu();
- virtual int GetCommandId(const NativeWebKeyboardEvent& event);
+ virtual bool PreHandleKeyboardEvent(const NativeWebKeyboardEvent& event,
+ bool* is_keyboard_shortcut);
+ virtual void HandleKeyboardEvent(const NativeWebKeyboardEvent& event);
virtual void ShowCreateShortcutsDialog(TabContents* tab_contents);
// Overridden from NotificationObserver
@@ -109,6 +111,9 @@
virtual void DestroyBrowser();
private:
+ int GetCommandId(const NativeWebKeyboardEvent& event);
+ bool HandleKeyboardEventInternal(NSEvent* event);
+
NotificationRegistrar registrar_;
NSWindow* window_; // weak, owned by controller
Browser* browser_; // weak, owned by controller
« no previous file with comments | « chrome/browser/chromeos/main_menu.h ('k') | chrome/browser/cocoa/browser_window_cocoa.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698