components/nacl/renderer/platform_info.h - Issue 399983002: Pepper: Refactor cpu feature attributes.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/nacl/renderer/platform_info.h

Issue 399983002: Pepper: Refactor cpu feature attributes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef COMPONENTS_NACL_RENDERER_PLATFORM_INFO_H

	6 #define COMPONENTS_NACL_RENDERER_PLATFORM_INFO_H

	7

	8 namespace nacl {

	9 // Returns the kind of SFI sandbox implemented by NaCl on this

	10 // platform. See the implementation in platform_info.cc for possible

	11 // values.

	12 const char* GetSandboxArch();

	13

	14 // Returns the feature attributes for the system's processor. Used for PNaCl

	15 // translation.

	16 std::string GetCpuFeatureAttrs();
	bbudge 2014/07/17 17:57:55 Since this now returns a string, perhaps it could Since this now returns a string, perhaps it could be called GetCpuFeatures? teravest 2014/07/17 18:01:40 Done. Show quoted text On 2014/07/17 17:57:55, bbudge wrote: > Since this now returns a string, perhaps it could be called GetCpuFeatures? Done.
	17 } // namespace nacl

	18

	19 #endif // COMPONENTS_NACL_RENDERER_PLATFORM_INFO_H

OLD	NEW