Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 399973004: Advanced printing destination settings modal dialog (non-functional yet, just the skeleton). (Closed)

Created:
6 years, 5 months ago by Aleksey Shlyapnikov
Modified:
6 years, 5 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Advanced printing destination settings modal dialog (non-functional yet, just the skeleton). BUG=394496 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284317

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+306 lines, -190 lines) Patch
M chrome/app/generated_resources.grd View 3 chunks +9 lines, -6 lines 0 comments Download
A + chrome/browser/resources/print_preview/common/search_box.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/print_preview/common/search_box.html View 1 chunk +4 lines, -0 lines 0 comments Download
A + chrome/browser/resources/print_preview/common/search_box.js View 5 chunks +20 lines, -24 lines 0 comments Download
M chrome/browser/resources/print_preview/print_header.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/print_preview/print_preview.html View 3 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/resources/print_preview/print_preview.js View 5 chunks +12 lines, -1 line 0 comments Download
M chrome/browser/resources/print_preview/search/destination_search.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/print_preview/search/destination_search.js View 2 chunks +3 lines, -2 lines 0 comments Download
D chrome/browser/resources/print_preview/search/search_box.css View 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/browser/resources/print_preview/search/search_box.html View 1 chunk +0 lines, -5 lines 0 comments Download
D chrome/browser/resources/print_preview/search/search_box.js View 1 chunk +0 lines, -124 lines 0 comments Download
A chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings.css View 1 chunk +36 lines, -0 lines 0 comments Download
A chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings.html View 1 chunk +16 lines, -0 lines 0 comments Download
A chrome/browser/resources/print_preview/settings/advanced_settings/advanced_settings.js View 1 chunk +192 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui.cc View 3 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Aleksey Shlyapnikov
6 years, 5 months ago (2014-07-17 20:38:01 UTC) #1
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 5 months ago (2014-07-18 19:04:14 UTC) #2
Aleksey Shlyapnikov
The CQ bit was checked by alekseys@chromium.org
6 years, 5 months ago (2014-07-19 00:19:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alekseys@chromium.org/399973004/1
6 years, 5 months ago (2014-07-19 00:20:58 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-19 05:02:07 UTC) #5
Message was sent while issue was closed. 
Change committed as 284317

Powered by Google App Engine
This is Rietveld 408576698