Issue 399973002: Work around DateTime creation flakiness

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 399973002: Work around DateTime creation flakiness (Closed)

Created:
6 years, 5 months ago by Alan Knight

Modified:
6 years, 5 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org, sigurdm, vsm

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Work around DateTime creation flakiness BUG= R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=38335

Patch Set 2 : Clarify TODO #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	pkg/intl/test/date_time_format_test_core.dart	View	1	1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Alan Knight

Another place where it seems we're getting bitten by DateTime creation occasionally dropping the time ...

6 years, 5 months ago (2014-07-17 16:47:58 UTC) #1

Emily Fortuna

lgtm, with one adjustment https://codereview.chromium.org/399973002/diff/1/pkg/intl/test/date_time_format_test_core.dart File pkg/intl/test/date_time_format_test_core.dart (right): https://codereview.chromium.org/399973002/diff/1/pkg/intl/test/date_time_format_test_core.dart#newcode378 pkg/intl/test/date_time_format_test_core.dart:378: // TODO(alanknight): Workaround for dartbug.com/15560. ...

6 years, 5 months ago (2014-07-17 16:57:22 UTC) #2

Alan Knight

6 years, 5 months ago (2014-07-17 17:16:53 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r38335 (presubmit successful).

Expand Messages | Collapse Messages

Issue 399973002: Work around DateTime creation flakiness (Closed)

Description

Patch Set 1 #

Patch Set 2 : Clarify TODO #

Messages