Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 399933002: Add UseCounter for <iframe allowfullscreen> exemption for <video> (Closed)

Created:
6 years, 5 months ago by philipj_slow
Modified:
6 years, 5 months ago
Reviewers:
falken
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Project:
blink
Visibility:
Public.

Description

Add UseCounter for <iframe allowfullscreen> exemption for <video> The video-specific fullscreen API can hopefully be retired soon, but if it can't it would still be valuable to get rid of this exemption, which could incentivise people to use the API. BUG=346236 R=falken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178420

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M Source/core/dom/FullscreenElementStack.cpp View 1 chunk +6 lines, -2 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
philipj_slow
PTAL
6 years, 5 months ago (2014-07-17 17:28:39 UTC) #1
falken
On 2014/07/17 17:28:39, philipj wrote: > PTAL LGTM
6 years, 5 months ago (2014-07-18 02:05:44 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 5 months ago (2014-07-18 06:01:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/399933002/1
6 years, 5 months ago (2014-07-18 06:02:56 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-18 06:37:52 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-18 07:13:06 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/17645)
6 years, 5 months ago (2014-07-18 07:13:07 UTC) #7
philipj_slow
6 years, 5 months ago (2014-07-18 07:36:24 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r178420 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698