Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 3999002: When zooming, webkit reports width and height as if the zoom wasn't there (by... (Closed)

Created:
10 years, 2 months ago by John Gregg
Modified:
9 years ago
Reviewers:
Jay Civelli
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

When zooming, webkit reports width and height as if the zoom wasn't there (by dividing the pixel size by the zoom factor). If we want actual pixel sizes that the content will best fit, we need to undo that. This affects HTML notifications which scale to the optimal size, when zooming has been applied. BUG=55160 TEST=HTML notifications from a domain where zooming is not 100%. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=63598

Patch Set 1 #

Patch Set 2 : fix windows build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/renderer/render_view.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
John Gregg
10 years, 2 months ago (2010-10-21 21:19:21 UTC) #1
Jay Civelli
10 years, 2 months ago (2010-10-22 16:30:46 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698