tools/telemetry/telemetry/value/skip.py - Issue 399893003: Add "description" attribute to Value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/value/skip.py

Issue 399893003: Add "description" attribute to Value. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix calls to Value constructor so that the tests pass. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/value/skip.py

diff --git a/tools/telemetry/telemetry/value/skip.py b/tools/telemetry/telemetry/value/skip.py

index a44e50893c2f9ab77518b78231c0bd5c6d6d7b8d..11eb3bc5cb6001a359a76d24177f0ae374bf3f30 100644

--- a/tools/telemetry/telemetry/value/skip.py

+++ b/tools/telemetry/telemetry/value/skip.py

@@ -6,14 +6,14 @@ from telemetry import value as value_module

class SkipValue(value_module.Value):

- def __init__(self, page, reason):

+ def __init__(self, page, reason, description=None):

"""A value representing a skipped page.

Args:

page: The skipped page object.

reason: The string reason the page was skipped.

"""

- super(SkipValue, self).__init__(page, 'skip', '', True)

+ super(SkipValue, self).__init__(page, 'skip', '', True, description)

self._reason = reason

def __repr__(self):

« no previous file with comments | « tools/telemetry/telemetry/value/scalar.py ('k') | tools/telemetry/telemetry/value/string.py » ('j') | no next file with comments »