Source/core/fileapi/FileReader.h - Issue 399863002: Gracefully handle FileReader() read operations when in a detached state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/fileapi/FileReader.h

Issue 399863002: Gracefully handle FileReader() read operations when in a detached state. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Throw AbortError (instead of InvalidStateError.) Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/files/resources/file-reader-detached-no-crash-new-window.html ('k') | Source/core/fileapi/FileReader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/fileapi/FileReader.h

diff --git a/Source/core/fileapi/FileReader.h b/Source/core/fileapi/FileReader.h

index 51904f026955b788fb6d92d47bff8d4ff1fbb855..634f864b71c0239f49553f76450654aede7e34df 100644

--- a/Source/core/fileapi/FileReader.h

+++ b/Source/core/fileapi/FileReader.h

@@ -100,16 +100,15 @@ public:

virtual void trace(Visitor*) OVERRIDE;

private:

- class ThrottlingController;

+ explicit FileReader(ExecutionContext*);

- FileReader(ExecutionContext*);

+ class ThrottlingController;

void terminate();

void readInternal(Blob*, FileReaderLoader::ReadType, ExceptionState&);

void fireErrorEvent(int httpStatusCode);

void fireEvent(const AtomicString& type);

- ThrottlingController* throttlingController();

void executePendingRead();

ReadyState m_state;