win: Add /d2Zi+ to compile flags

win: Add /d2Zi+ to compile flags

This makes debugging and stacks in Release builds much more accurate
(locals, arguments, information about inlining, etc.). The drawback is
somewhat larger .pdb files. Here's the sizes for the top 10 pdbs:

With /d2Zi+
-----------
07/17/2014  09:52 PM       280,408,064 content_unittests.exe.pdb
07/17/2014  09:47 PM       477,401,088 blink_web.dll.pdb
07/17/2014  09:50 PM       506,949,632 content.dll.pdb
07/17/2014  10:01 PM       955,576,320 sync_performance_tests.exe.pdb
07/17/2014  09:59 PM       955,912,192 performance_browser_tests.exe.pdb
07/17/2014  10:04 PM       965,382,144 sync_integration_tests.exe.pdb
07/17/2014  09:59 PM       987,688,960 chrome.dll.pdb
07/17/2014  10:03 PM     1,228,763,136 interactive_ui_tests.exe.pdb
07/17/2014  10:05 PM     1,398,632,448 browser_tests.exe.pdb
07/17/2014  10:07 PM     1,569,222,656 unit_tests.exe.pdb

Without
-------

07/17/2014  10:44 PM       238,104,576 content_unittests.exe.pdb
07/17/2014  10:39 PM       399,175,680 blink_web.dll.pdb
07/17/2014  10:44 PM       439,767,040 content.dll.pdb
07/17/2014  10:57 PM       837,832,704 sync_performance_tests.exe.pdb
07/17/2014  10:51 PM       838,119,424 performance_browser_tests.exe.pdb
07/17/2014  10:57 PM       846,286,848 sync_integration_tests.exe.pdb
07/17/2014  10:51 PM       864,194,560 chrome.dll.pdb
07/17/2014  10:58 PM     1,071,509,504 interactive_ui_tests.exe.pdb
07/17/2014  10:58 PM     1,219,203,072 browser_tests.exe.pdb
07/17/2014  10:58 PM     1,351,118,848 unit_tests.exe.pdb

So there is appreciable growth (~15%). The limit is currently 4G, so it
seems worth turning on for now, and if we must disable it later, we can.

R=wfh@chromium.org
BUG=350018, 388264
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284043

[Will Harris, 2014-07-18 06:11:17]

On 2014/07/18 06:06:31, scottmg wrote:

LGTM. We should double check crash symbolization still works fine once this hits
Canary.

[scottmg, 2014-07-18 06:14:27]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2014-07-18 06:15:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/scottmg@chromium.org/399843007/1

[commit-bot: I haz the power, 2014-07-18 09:30:39]

Change committed as 284043

[Nico, 2015-08-17 22:34:39]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2015-08-17 22:34:39]

I was comparing gn and gyp builds a bit and noticed that these two flags are
passed in gyp but not gn. Is this intentional?

[scottmg, 2015-08-17 22:42:54]

On 2015/08/17 22:34:39, Nico wrote:
> I was comparing gn and gyp builds a bit and noticed that these two flags are
> passed in gyp but not gn. Is this intentional?

/d2Zi+ should be passed in GN too. (but that's only 1 flag? or do you mean the
"extra" thing?)

[Nico, 2015-08-17 22:46:26]

/Zc:inline too, but it turns out I was comparing a release gyp build with a
debug gn build :-| sorry for the noise, nothing to see here. (Except me looking
silly.)