Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 399833002: Use build/repack_action.gypi instead of doing it manually. (Closed)

Created:
6 years, 5 months ago by lcwu1
Modified:
6 years, 3 months ago
Reviewers:
tfarina, damienv1, gunsch
CC:
chromium-reviews, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use build/repack_action.gypi instead of doing it manually. BUG=394474 R=tfarina@chromium.org,gunsch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283949

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M chromecast/common/chromecast_config.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M chromecast/shell/browser/url_request_context_factory.cc View 1 2 4 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
gunsch
lgtm
6 years, 5 months ago (2014-07-17 02:48:08 UTC) #1
tfarina
lgtm
6 years, 5 months ago (2014-07-17 03:11:09 UTC) #2
lcwu1
The CQ bit was checked by lcwu@chromium.org
6 years, 5 months ago (2014-07-17 17:22:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lcwu@chromium.org/399833002/20001
6 years, 5 months ago (2014-07-17 17:23:36 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-17 22:34:39 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 00:50:52 UTC) #6
Message was sent while issue was closed.
Change committed as 283949

Powered by Google App Engine
This is Rietveld 408576698