Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 399803002: mac: Fix tab dragging visual bug in Yosemite. (reland 2) (Closed)

Created:
6 years, 5 months ago by erikchen
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

mac: Fix tab dragging visual bug in Yosemite. (reland 2) -----------------Reland 2 Description------------------ Turned on layers for the test for fullscreen windows. -----------------Reland 1 Description------------------ Reland 1 link: https://codereview.chromium.org/393933003/ Core animation was turned on in M35. The fullscreen window was not layer backed, but should have been. This original CL exposed this bug. -----------------Original Description------------------ Original CL link: https://codereview.chromium.org/379293003/ In OSX 10.10+, all views must be added to the NSWindow's contentView. Some views (like the tab strip and the profile icon) are placed on top of the title bar and require special treatment. All other views are added as subviews of 'chromeContentView' in TabWindowController. This allows tab dragging and fullscreen logic to easily move the views that don't need special treatment. This CL also removes the instances where a VersionIndependentWindow's contentView gets replaced by setContentView:. Instead, the 'chromeContentView' gets passed around as a subview. This allows VersionIndependentWindow to remove another of its internal hacks. BUG=392239 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283650

Patch Set 1 : Copy of patch set 2 from https://codereview.chromium.org/393933003/ #

Patch Set 2 : Add layer backing to fullscreen test window. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -26 lines) Patch
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 4 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_unittest.mm View 1 3 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/fullscreen_window.mm View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_window_controller.h View 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_window_controller.mm View 5 chunks +24 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/version_independent_window.mm View 2 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
erikchen
shess: Please review.
6 years, 5 months ago (2014-07-17 00:10:25 UTC) #1
Scott Hess - ex-Googler
Change LGTM, but ... is there something causing this to miss trybot coverage or something?
6 years, 5 months ago (2014-07-17 00:13:01 UTC) #2
erikchen
yeah, the exception being raised in an OSX 10.6 bug, and the trybots don't run ...
6 years, 5 months ago (2014-07-17 00:17:45 UTC) #3
erikchen
The CQ bit was checked by erikchen@chromium.org
6 years, 5 months ago (2014-07-17 00:20:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikchen@chromium.org/399803002/20001
6 years, 5 months ago (2014-07-17 00:23:39 UTC) #5
commit-bot: I haz the power
Change committed as 283650
6 years, 5 months ago (2014-07-17 05:10:12 UTC) #6
erikchen
6 years, 4 months ago (2014-07-29 01:17:32 UTC) #7
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/423013005/ by erikchen@chromium.org.

The reason for reverting is: NSInvalidArgumentException reason Unlocking Focus
on wrong view (<NSView: 0x#>), expected <FastResizeView: 0x#>	

https://code.google.com/p/chromium/issues/detail?id=397089.

Powered by Google App Engine
This is Rietveld 408576698