Add more testing to QUIC's BbrTcpSender to verify it shares bandwidth

net/quic/congestion_control/send_algorithm_simulator.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/congestion_control/send_algorithm_simulator.h"
 
 #include <limits>
 
 #include "base/logging.h"
 #include "base/rand_util.h"
@@ skipping 88 matching lines @@
       DVLOG(1) << "Sending, advancing time:"
                << send_event.time_delta.ToMicroseconds() << "us";
       clock_->AdvanceTime(send_event.time_delta);
       SendDataNow(send_event.transfer);
       bytes_sent += kPacketSize;
     }
   }
 }
 
 SendAlgorithmSimulator::PacketEvent SendAlgorithmSimulator::NextSendEvent() {
-  QuicTime::Delta send_time = QuicTime::Delta::Infinite();
+  QuicTime::Delta next_send_time = QuicTime::Delta::Infinite();
   Transfer* transfer = NULL;
   for (vector<Transfer>::iterator it = pending_transfers_.begin();
        it != pending_transfers_.end(); ++it) {
-    // If the flow hasn't started, return the start time.
-    if (clock_->Now() < it->start_time) {
-      send_time = it->start_time.Subtract(clock_->Now());
-      transfer = &(*it);
-      continue;
-    }
     // If we've already sent enough bytes, wait for them to be acked.
     if (it->bytes_acked + it->bytes_in_flight >= it->num_bytes) {
       continue;
     }
-    QuicTime::Delta transfer_send_time =
-        it->sender->send_algorithm->TimeUntilSend(
-            clock_->Now(), it->bytes_in_flight, HAS_RETRANSMITTABLE_DATA);
-    if (transfer_send_time < send_time) {
-      send_time = transfer_send_time;
+    // If the flow hasn't started, use the start time.
+    QuicTime::Delta transfer_send_time = it->start_time.Subtract(clock_->Now());
+    if (clock_->Now() >= it->start_time) {
+      transfer_send_time =
+          it->sender->send_algorithm->TimeUntilSend(
+              clock_->Now(), it->bytes_in_flight, HAS_RETRANSMITTABLE_DATA);
+    }
+    if (transfer_send_time < next_send_time) {
+      next_send_time = transfer_send_time;
       transfer = &(*it);
     }
   }
-  DVLOG(1) << "NextSendTime returning delta(ms):" << send_time.ToMilliseconds();
-  return PacketEvent(send_time, transfer);
+  DVLOG(1) << "NextSendTime returning delta(ms):"
+           << next_send_time.ToMilliseconds();
+  return PacketEvent(next_send_time, transfer);
 }
 
 // NextAck takes into account packet loss in both forward and reverse
 // direction, as well as correlated losses.  And it assumes the receiver acks
 // every other packet when there is no loss.
 SendAlgorithmSimulator::PacketEvent SendAlgorithmSimulator::NextAckEvent() {
   if (sent_packets_.empty()) {
     DVLOG(1) << "No outstanding packets to ack for any transfer.";
     return PacketEvent(QuicTime::Delta::Infinite(), NULL);
   }
 
   // For each connection, find the next acked packet.
   QuicTime::Delta ack_time = QuicTime::Delta::Infinite();
   Transfer* transfer = NULL;
   for (vector<Transfer>::iterator it = pending_transfers_.begin();
        it != pending_transfers_.end(); ++it) {
-    // If necessary, determine next_acked_.
-    // This is only done once to ensure multiple calls return the same time.
     QuicTime::Delta transfer_ack_time = FindNextAcked(&(*it));
     if (transfer_ack_time < ack_time) {
       ack_time = transfer_ack_time;
       transfer = &(*it);
     }
   }
 
   return PacketEvent(ack_time, transfer);
 }
 
 QuicTime::Delta SendAlgorithmSimulator::FindNextAcked(Transfer* transfer) {
-  Sender* sender  = transfer->sender;
+  Sender* sender = transfer->sender;
   if (sender->next_acked == sender->last_acked) {
     // Determine if the next ack is lost only once, to ensure determinism.
     lose_next_ack_ =
         reverse_loss_rate_ * kuint64max > simple_random_.RandUint64();
   }
   bool two_acks_remaining = lose_next_ack_;
   sender->next_acked = sender->last_acked;
   bool packets_lost = false;
   // Remove any packets that are simulated as lost.
   for (list<SentPacket>::const_iterator it = sent_packets_.begin();
        it != sent_packets_.end(); ++it) {
     if (transfer != it->transfer) {
       continue;
     }
 
     // Lost packets don't trigger an ack.
-    if (it->ack_time  == QuicTime::Zero()) {
+    if (it->ack_time == QuicTime::Zero()) {
       packets_lost = true;
       continue;
     }
     // Buffer dropped packets are skipped automatically, but still end up
     // being lost and cause acks to be sent immediately.
     if (sender->next_acked < it->sequence_number - 1) {
       packets_lost = true;
     }
+    DCHECK_LT(sender->next_acked, it->sequence_number);
     sender->next_acked = it->sequence_number;
     if (packets_lost || (sender->next_acked - sender->last_acked) % 2 == 0) {
       if (two_acks_remaining) {
         two_acks_remaining = false;
       } else {
         break;
       }
     }
   }
+  // If the connection has no packets to be acked, return Infinite.
+  if (sender->next_acked == sender->last_acked) {
+    return QuicTime::Delta::Infinite();
+  }
 
   QuicTime::Delta ack_time = QuicTime::Delta::Infinite();
   for (list<SentPacket>::const_iterator it = sent_packets_.begin();
        it != sent_packets_.end(); ++it) {
     if (transfer == it->transfer && sender->next_acked == it->sequence_number) {
       ack_time = it->ack_time.Subtract(clock_->Now());
     }
   }
   // If only one packet is acked, simulate a delayed ack.
   if (!ack_time.IsInfinite() && transfer->bytes_in_flight == kPacketSize) {
     ack_time = ack_time.Add(QuicTime::Delta::FromMilliseconds(100));
   }
   DVLOG(1) << "FindNextAcked found next_acked_:"
            << transfer->sender->next_acked
            << " last_acked:" << transfer->sender->last_acked
            << " ack_time(ms):" << ack_time.ToMilliseconds();
   return ack_time;
 }
 
 void SendAlgorithmSimulator::HandlePendingAck(Transfer* transfer) {
   Sender* sender  = transfer->sender;
   DCHECK_LT(sender->last_acked, sender->next_acked);
   SendAlgorithmInterface::CongestionMap acked_packets;
   SendAlgorithmInterface::CongestionMap lost_packets;
   // Some entries may be missing from the sent_packets_ array, if they were
   // dropped due to buffer overruns.
-  SentPacket largest_observed = sent_packets_.front();
+  SentPacket largest_observed(0, QuicTime::Zero(), QuicTime::Zero(), NULL);
+  list<SentPacket>::iterator it = sent_packets_.begin();
   while (sender->last_acked < sender->next_acked) {
     ++sender->last_acked;
     TransmissionInfo info = TransmissionInfo();
     info.bytes_sent = kPacketSize;
     info.in_flight = true;
+    // Find the next SentPacket for this transfer.
+    while (it->transfer != transfer) {
+      DCHECK(it != sent_packets_.end());
+      ++it;
+    }
     // If it's missing from the array, it's a loss.
-    if (sent_packets_.front().sequence_number > sender->last_acked) {
+    if (it->sequence_number > sender->last_acked) {
       DVLOG(1) << "Lost packet:" << sender->last_acked
                << " dropped by buffer overflow.";
       lost_packets[sender->last_acked] = info;
       continue;
     }
-    if (sent_packets_.front().ack_time.IsInitialized()) {
+    if (it->ack_time.IsInitialized()) {
       acked_packets[sender->last_acked] = info;
     } else {
       lost_packets[sender->last_acked] = info;
     }
-    // Remove all packets from the front to next_acked_.
-    largest_observed = sent_packets_.front();
-    sent_packets_.pop_front();
+    // This packet has been acked or lost, remove it from sent_packets_.
+    largest_observed = *it;
+    sent_packets_.erase(it++);
   }
 
   DCHECK(largest_observed.ack_time.IsInitialized());
+  DVLOG(1) << "Updating RTT from send_time:"
+           << largest_observed.send_time.ToDebuggingValue() << " to ack_time:"
+           << largest_observed.ack_time.ToDebuggingValue();
   sender->rtt_stats->UpdateRtt(
       largest_observed.ack_time.Subtract(largest_observed.send_time),
       QuicTime::Delta::Zero(),
       clock_->Now());
   sender->send_algorithm->OnCongestionEvent(
       true, transfer->bytes_in_flight, acked_packets, lost_packets);
   DCHECK_LE(kPacketSize * (acked_packets.size() + lost_packets.size()),
             transfer->bytes_in_flight);
   transfer->bytes_in_flight -=
       kPacketSize * (acked_packets.size() + lost_packets.size());
@@ skipping 40 matching lines @@
     DVLOG(1) << "losing packet:" << sender->last_sent
              << " due to random loss.";
 
     QuicTime ack_time = clock_->Now().Add(rtt_);
     // If the number of bytes in flight are less than the bdp, there's
     // no buffering delay.  Bytes lost from the buffer are not counted.
     QuicByteCount bdp = bandwidth_.ToBytesPerPeriod(rtt_);
     if ((sent_packets_.size() + 1) * kPacketSize > bdp) {
       QuicByteCount qsize = (sent_packets_.size() + 1) * kPacketSize - bdp;
       ack_time = ack_time.Add(bandwidth_.TransferTime(qsize));
+      DVLOG(1) << "Increasing transfer time:"
+               << bandwidth_.TransferTime(qsize).ToMilliseconds()
+               << "ms due to qsize:" << qsize;
     }
     // If the packet is lost, give it an ack time of Zero.
     sent_packets_.push_back(SentPacket(
         sender->last_sent, clock_->Now(),
         packet_lost ? QuicTime::Zero() : ack_time, transfer));
   } else {
     DVLOG(1) << "losing packet:" << sender->last_sent
              << " because the buffer was full.";
   }
   transfer->bytes_in_flight += kPacketSize;
 }
 
 // Advance the time by |delta| without sending anything.
 void SendAlgorithmSimulator::AdvanceTime(QuicTime::Delta delta) {
   clock_->AdvanceTime(delta);
 }
 
 }  // namespace net