Issue 399773003: QUIC test only change to add a convenience operator for printing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 399773003: QUIC test only change to add a convenience operator for printing (Closed)

Created:
6 years, 5 months ago by ramant (doing other things)

Modified:
6 years, 5 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

QUIC test only change to add a convenience operator for printing SendAlgorithmSimulator stats. Merge internal change: 70897829 R=rch@chromium.org

Patch Set 1 #

Total comments: 2

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
	M	net/quic/congestion_control/send_algorithm_simulator.h	View		2 chunks	+14 lines, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

lgtm https://codereview.chromium.org/399773003/diff/1/net/quic/congestion_control/send_algorithm_simulator.h File net/quic/congestion_control/send_algorithm_simulator.h (right): https://codereview.chromium.org/399773003/diff/1/net/quic/congestion_control/send_algorithm_simulator.h#newcode49 net/quic/congestion_control/send_algorithm_simulator.h:49: } I suspect you'll need to move this ...

6 years, 5 months ago (2014-07-17 00:02:46 UTC) #3

ramant (doing other things)

6 years, 5 months ago (2014-07-18 18:02:25 UTC) #4

https://codereview.chromium.org/399773003/diff/1/net/quic/congestion_control/...
File net/quic/congestion_control/send_algorithm_simulator.h (right):

https://codereview.chromium.org/399773003/diff/1/net/quic/congestion_control/...
net/quic/congestion_control/send_algorithm_simulator.h:49: }
On 2014/07/17 00:02:46, Ryan Hamilton wrote:
> I suspect you'll need to move this to the .cc file.

I am surprised, not sure why compiler's didn't complain(I thought I may have to
move the code into .cc file too).

Left the code similar to the internal source tree.

Expand Messages | Collapse Messages