Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1165)

Issue 399753005: Fix off-by-one error in Array.concat slow mode check (Closed)

Created:
6 years, 5 months ago by Jakob Kummerow
Modified:
6 years, 5 months ago
Reviewers:
Yang
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix off-by-one error in Array.concat slow mode check BUG=chromium:395499 LOG=n R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22494

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/runtime.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
6 years, 5 months ago (2014-07-21 09:40:08 UTC) #1
Yang
On 2014/07/21 09:40:08, Jakob wrote: lgtm.
6 years, 5 months ago (2014-07-21 09:41:30 UTC) #2
Jakob Kummerow
6 years, 5 months ago (2014-07-21 09:42:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22494 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698