Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: media/cast/net/pacing/paced_sender.h

Issue 399743002: Cast: Implement priority packets in PacedSender (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/cast/net/cast_transport_sender_impl.cc ('k') | media/cast/net/pacing/paced_sender.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cast/net/pacing/paced_sender.h
diff --git a/media/cast/net/pacing/paced_sender.h b/media/cast/net/pacing/paced_sender.h
index c9f0512eb0ca9212af029e28169bd465a8980c83..094e5299e102e2affedaadca26a0435759baf9ae 100644
--- a/media/cast/net/pacing/paced_sender.h
+++ b/media/cast/net/pacing/paced_sender.h
@@ -5,7 +5,7 @@
#ifndef MEDIA_CAST_NET_PACING_PACED_SENDER_H_
#define MEDIA_CAST_NET_PACING_PACED_SENDER_H_
-#include <list>
+#include <map>
#include <vector>
#include "base/basictypes.h"
@@ -69,6 +69,12 @@ class PacedSender : public PacedPacketSender,
void RegisterAudioSsrc(uint32 audio_ssrc);
void RegisterVideoSsrc(uint32 video_ssrc);
+ // Register SSRC that has a higher priority for sending. Multiple SSRCs can
+ // be registered.
+ // Note that it is not expected to register many SSRCs with this method.
+ // Because IsHigherPriority() is determined in linear time.
+ void RegisterPrioritySsrc(uint32 ssrc);
+
// PacedPacketSender implementation.
virtual bool SendPackets(const SendPacketVector& packets) OVERRIDE;
virtual bool ResendPackets(const SendPacketVector& packets,
@@ -108,16 +114,25 @@ class PacedSender : public PacedPacketSender,
// Returns the next packet to send. RTCP packets have highest priority,
// resend packets have second highest priority and then comes everything
// else.
- PacketRef GetNextPacket(PacketType* packet_type,
+ PacketRef PopNextPacket(PacketType* packet_type,
PacketKey* packet_key);
+ // Returns true if the packet should have a higher priority.
+ bool IsHighPriority(const PacketKey& packet_key) const;
+
base::TickClock* const clock_; // Not owned by this class.
LoggingImpl* const logging_; // Not owned by this class.
PacketSender* transport_; // Not owned by this class.
scoped_refptr<base::SingleThreadTaskRunner> transport_task_runner_;
uint32 audio_ssrc_;
uint32 video_ssrc_;
- std::map<PacketKey, std::pair<PacketType, PacketRef> > packet_list_;
+
+ // Set of SSRCs that have higher priority. This is a vector instead of a
+ // set because there's only very few in it (most likely 1).
+ std::vector<uint32> priority_ssrcs_;
+ typedef std::map<PacketKey, std::pair<PacketType, PacketRef> > PacketList;
+ PacketList packet_list_;
+ PacketList priority_packet_list_;
std::map<PacketKey, base::TimeTicks> sent_time_;
std::map<PacketKey, base::TimeTicks> sent_time_buffer_;
« no previous file with comments | « media/cast/net/cast_transport_sender_impl.cc ('k') | media/cast/net/pacing/paced_sender.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698