Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 399733006: Update angle to a1851e8. (Closed)

Created:
6 years, 5 months ago by Peter Kasting
Modified:
6 years, 5 months ago
CC:
chromium-reviews, Geoff Lang
Visibility:
Public.

Description

Update angle to a1851e8. This includes the following changes: a1851e8 Fixes for re-enabling more MSVC level 4 warnings: angle/ edition 6518fe2 Moved TextureStorage and Image into d3d d4cfa57 Move more draw call validation to the API. f6d38b0 Fix CollectVariablesTest GCC/Clang compile errors. 4e1fd41 Store a map of interface block registers. 829e89e Add a default constructor to sh::ShaderVariable. d5512cd Collect shader outputs and interface block information. 0b7e5d8 Fix 64-bit warnings. c0b9ef4 Split Caps into Caps, Extensions and TextureFormatCaps. 57f9b6d Clean up generatemip.h. 86846e2 Clean up the functions in loadimage.h/cpp. 2a6564e Fix build errors in validationES.cpp. e92a354 Remove redundant FBO query methods. 55ec3b1 Refactor common attachment validation to base method. 23a8a43 Store compact and expanded shader variables. aae65a4 Add caps for texture size limits and other caps in the 6.28 table. 77f7485 Add a GetVariableInfo helper method. 93455eb Add missing limits include to angleutils.h 4667c45 Refactor style in VariableInfo.cpp. 53cb14d Share ArrayString and Str helper methods. b23375f Fixed an issue with Streaming Vertex data overflowing it's buffer. aa7e166 Improve the const correctness. b447227 Add a ValidateAttachmentTarget helper method. 570f7c8 Add helper methods for FBO attachment validation. a328d56 Removed sampler state getters and setters from gl::Texture BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283877

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Peter Kasting
6 years, 5 months ago (2014-07-16 23:30:21 UTC) #1
Jamie Madill
LGTM if bots are happy... some other changes rolled into there. Geoff: FYI
6 years, 5 months ago (2014-07-17 00:17:06 UTC) #2
Jamie Madill
Also, I'm not a chrome committer so you will have to TBR or find another ...
6 years, 5 months ago (2014-07-17 00:17:59 UTC) #3
Peter Kasting
Ken, want to give this a committer's stamp of approval?
6 years, 5 months ago (2014-07-17 01:12:50 UTC) #4
Ken Russell (switch to Gerrit)
LGTM if it passes the GPU bots on the CQ.
6 years, 5 months ago (2014-07-17 18:26:13 UTC) #5
Peter Kasting
The CQ bit was checked by pkasting@chromium.org
6 years, 5 months ago (2014-07-17 18:26:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkasting@chromium.org/399733006/1
6 years, 5 months ago (2014-07-17 18:30:55 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 21:16:46 UTC) #8
Message was sent while issue was closed.
Change committed as 283877

Powered by Google App Engine
This is Rietveld 408576698