Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 399723002: Remove base/network_change_notifier_linux_unittest.cc exclusion. (Closed)

Created:
6 years, 5 months ago by Jun Mukai
Modified:
6 years, 5 months ago
Reviewers:
szym, brettw
CC:
chromium-reviews, cbentzel+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove base/network_change_notifier_linux_unittest.cc exclusion. It seems this file doesn't exist anymore, so the exclusion rules aren't also necessary. And GN reports error for excluding non-existing files. BUG=None R=brettw@chromium.org, szym@chromium.org TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283655

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M net/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M net/net.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Jun Mukai
6 years, 5 months ago (2014-07-16 20:22:56 UTC) #1
szym
lgtm
6 years, 5 months ago (2014-07-16 20:27:46 UTC) #2
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 5 months ago (2014-07-16 20:34:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/399723002/1
6 years, 5 months ago (2014-07-16 20:37:37 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-17 00:19:50 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 06:16:52 UTC) #6
Message was sent while issue was closed.
Change committed as 283655

Powered by Google App Engine
This is Rietveld 408576698