Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 399693002: Add media/test/data to content_browsertests and browser_tests isolate files. (Closed)

Created:
6 years, 5 months ago by shadi
Modified:
6 years, 5 months ago
Reviewers:
csharp
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

Add media/test/data to content_browsertests and browser_tests isolate files. The media browser tests (content and chrome) load data from media/test/data. BUG=379314 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283757

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser_tests.isolate View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_browsertests.isolate View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
shadi
Hi Chris, can you PTAL? This CL should fix the failures I saw after committing ...
6 years, 5 months ago (2014-07-16 18:08:25 UTC) #1
csharp
lgtm
6 years, 5 months ago (2014-07-16 19:25:36 UTC) #2
shadi
The CQ bit was checked by shadi@chromium.org
6 years, 5 months ago (2014-07-16 19:43:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shadi@chromium.org/399693002/1
6 years, 5 months ago (2014-07-16 19:45:58 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 22:17:36 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 11:53:59 UTC) #6
Message was sent while issue was closed.
Change committed as 283757

Powered by Google App Engine
This is Rietveld 408576698