JPEG YUV Decoding

src/images/SkDecodingImageGenerator.cpp

Index: src/images/SkDecodingImageGenerator.cpp
diff --git a/src/images/SkDecodingImageGenerator.cpp b/src/images/SkDecodingImageGenerator.cpp
index 3b5cb784edd4254f2c7ce4b51ad7d4c2dfe02b4a..0518a5c0c901cec411300e7c6754f2122cdd2e57 100644
--- a/src/images/SkDecodingImageGenerator.cpp
+++ b/src/images/SkDecodingImageGenerator.cpp
@@ -45,6 +45,8 @@ protected:
     virtual bool onGetPixels(const SkImageInfo& info,
                              void* pixels, size_t rowBytes,
                              SkPMColor ctable[], int* ctableCount) SK_OVERRIDE;
+    virtual bool onGetYUV8Planes(SkISize sizes[3], void* planes[3], size_t rowBytes[3],
+                                 SkYUVColorSpace* colorSpace) SK_OVERRIDE;
 
 private:
     typedef SkImageGenerator INHERITED;
@@ -204,6 +206,24 @@ bool DecodingImageGenerator::onGetPixels(const SkImageInfo& info,
     return true;
 }
 
+bool DecodingImageGenerator::onGetYUV8Planes(SkISize sizes[3], void* planes[3],
+                                             size_t rowBytes[3], SkYUVColorSpace* colorSpace) {

[reed1, 2014/10/13 13:15:35]

where do we set colorSpace? Seems like we need the codec to tell us that...

[sugoi1, 2014/10/14 15:07:36]

I set it here. For now I set it unconditionally to the JPEG YUV format, as the
only other one available currently is for video. I'll add a virtual function in
the decoder once we have more than 1 possible choice.

[reed1, 2014/10/14 15:34:28]

I don't see where "here" is.

[sugoi1, 2014/10/14 15:46:37]

Sorry, I meant: in this function (next version of the file)

+    if (!fStream->rewind()) {
+        return false;
+    }
+
+    SkAutoTDelete<SkImageDecoder> decoder(SkImageDecoder::Factory(fStream));
+    if (NULL == decoder.get()) {
+        return false;
+    }
+
+    if (!planes || !planes[0]) {
+		return decoder->getYUVComponentSizes(fStream, sizes);
+    }
+    
+    return decoder->decodeToYUV(fStream, sizes, planes, rowBytes);
+}
+
 // A contructor-type function that returns NULL on failure.  This
 // prevents the returned SkImageGenerator from ever being in a bad
 // state.  Called by both Create() functions