Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 399683005: Enable more tests in GN build. (Closed)

Created:
6 years, 5 months ago by brettw
Modified:
6 years, 5 months ago
Reviewers:
jamesr
CC:
chromium-reviews, tim+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, sadrul, zea+watch_chromium.org, tdresser+watch_chromium.org, Ian Vollick, jam, haitaol+watch_chromium.org, piman+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, eme-reviews_chromium.org, darin-cc_chromium.org, tfarina, kalyank, cc-bugs_chromium.org, danakj+watch_chromium.org, ben+ash_chromium.org, maniscalco+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Enable more tests in GN build. Add components/cdm, components/sync_driver, ui/app_list, Update file lists that got out of sync with GYP to to not having any targets that actually link them. Move cc:cc_surfaces to cc/surfaces Enable linking cc_unittests, cc_perftests, app_list_unittests, message_center_unittests TBR=jamesr Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284784

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Fix android #

Patch Set 5 : no cdm on android #

Patch Set 6 : no pango #

Patch Set 7 : #

Patch Set 8 : printing mode #

Patch Set 9 : more android printing mode #

Unified diffs Side-by-side diffs Delta from patch set Stats (+646 lines, -99 lines) Patch
M BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M ash/BUILD.gn View 1 2 3 4 5 6 9 chunks +24 lines, -24 lines 0 comments Download
M cc/BUILD.gn View 5 chunks +32 lines, -33 lines 0 comments Download
M cc/cc.gyp View 4 chunks +4 lines, -0 lines 0 comments Download
M cc/cc_tests.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
A cc/surfaces/BUILD.gn View 1 chunk +39 lines, -0 lines 0 comments Download
M components/BUILD.gn View 1 2 3 4 5 6 6 chunks +16 lines, -11 lines 0 comments Download
M components/cdm.gypi View 3 chunks +3 lines, -0 lines 0 comments Download
A + components/cdm/browser/BUILD.gn View 1 chunk +6 lines, -8 lines 0 comments Download
A + components/cdm/common/BUILD.gn View 1 chunk +5 lines, -2 lines 0 comments Download
A components/cdm/renderer/BUILD.gn View 1 2 3 1 chunk +25 lines, -0 lines 0 comments Download
M components/sync_driver.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
A components/sync_driver/BUILD.gn View 1 chunk +91 lines, -0 lines 0 comments Download
M content/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M skia/BUILD.gn View 1 2 3 4 5 6 7 8 2 chunks +18 lines, -10 lines 0 comments Download
M skia/skia_chrome.gypi View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
A ui/app_list/BUILD.gn View 1 chunk +231 lines, -0 lines 0 comments Download
M ui/app_list/app_list.gyp View 6 chunks +6 lines, -0 lines 0 comments Download
M ui/base/BUILD.gn View 1 2 3 4 5 9 chunks +91 lines, -3 lines 0 comments Download
M ui/compositor/BUILD.gn View 2 chunks +6 lines, -2 lines 0 comments Download
M ui/events/events.gyp View 10 chunks +12 lines, -0 lines 0 comments Download
M ui/gfx/geometry/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/message_center/BUILD.gn View 2 chunks +0 lines, -5 lines 0 comments Download
M ui/views/BUILD.gn View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/controls/webview/BUILD.gn View 1 chunk +24 lines, -0 lines 0 comments Download
M ui/views/controls/webview/webview_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
6 years, 5 months ago (2014-07-22 19:29:57 UTC) #1
brettw
Committed patchset #9 manually as r284784 (presubmit successful).
6 years, 5 months ago (2014-07-22 21:51:43 UTC) #2
jamesr
6 years, 5 months ago (2014-07-23 00:00:33 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698