Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 399663002: Have mojo_shell run in its custom thread on android. (Closed)

Created:
6 years, 5 months ago by qsr
Modified:
6 years, 5 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Have mojo_shell run in its custom thread on android. The native viewport service on android must run on the main thread of the application. Because it is expected at the moment to run on its own thread, this CL move the shell thread on android to a secondary background thread and use the main thread of the application for the native viewport service. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283764

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -25 lines) Patch
M mojo/mojo.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/shell/android/apk/src/org/chromium/mojo_shell_apk/MojoMain.java View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/shell/android/apk/src/org/chromium/mojo_shell_apk/MojoShellActivity.java View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/android/mojo_main.cc View 4 chunks +19 lines, -9 lines 0 comments Download
M mojo/shell/context.h View 2 chunks +3 lines, -0 lines 0 comments Download
M mojo/shell/context.cc View 3 chunks +10 lines, -0 lines 0 comments Download
M mojo/shell/dbus_service_loader_linux.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/shell/keep_alive.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/task_runners.h View 2 chunks +4 lines, -5 lines 0 comments Download
M mojo/shell/task_runners.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A mojo/shell/ui_service_loader_android.h View 1 chunk +58 lines, -0 lines 0 comments Download
A mojo/shell/ui_service_loader_android.cc View 1 chunk +89 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
qsr
This should solve the issue with the shell on android, without forcing the view manager ...
6 years, 5 months ago (2014-07-16 15:47:51 UTC) #1
darin (slow to review)
I think you should fix the CL description. It's the native viewport service, not the ...
6 years, 5 months ago (2014-07-16 17:49:43 UTC) #2
darin (slow to review)
LGTM
6 years, 5 months ago (2014-07-16 17:49:50 UTC) #3
qsr
On 2014/07/16 17:49:43, darin wrote: > I think you should fix the CL description. It's ...
6 years, 5 months ago (2014-07-17 08:00:39 UTC) #4
qsr
The CQ bit was checked by qsr@chromium.org
6 years, 5 months ago (2014-07-17 08:01:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/399663002/1
6 years, 5 months ago (2014-07-17 08:06:06 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-17 08:44:42 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-17 08:46:02 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/29611)
6 years, 5 months ago (2014-07-17 08:46:02 UTC) #9
qsr
The CQ bit was checked by qsr@chromium.org
6 years, 5 months ago (2014-07-17 09:56:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/399663002/20001
6 years, 5 months ago (2014-07-17 09:58:07 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 13:01:58 UTC) #12
Message was sent while issue was closed.
Change committed as 283764

Powered by Google App Engine
This is Rietveld 408576698