Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Unified Diff: mojo/mojo_examples.gypi

Issue 399653004: Add a Mojo example apptest that runs in mojo_shell. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« mojo/examples/test/example_unittest.cc ('K') | « mojo/mojo.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/mojo_examples.gypi
diff --git a/mojo/mojo_examples.gypi b/mojo/mojo_examples.gypi
index 8e8cf0c750a51f75d07e0d76ed3c8378e6b0ca90..3f42c983de6ff63fa7333dba4560dd6c16cfce2a 100644
--- a/mojo/mojo_examples.gypi
+++ b/mojo/mojo_examples.gypi
@@ -37,6 +37,79 @@
'includes': [ 'build/package_app.gypi' ],
},
{
+ 'target_name': 'mojo_example_service_bindings',
+ 'type': 'static_library',
+ 'sources': [
+ # TODO(msw): Move to examples/services/public/interfaces/example ???
+ 'examples/test/example_service.mojom',
+ ],
+ 'includes': [ 'public/tools/bindings/mojom_bindings_generator.gypi' ],
+ 'export_dependent_settings': [
+ 'mojo_cpp_bindings',
+ ],
+ 'dependencies': [
+ 'mojo_cpp_bindings',
+ ],
+ },
+ { # TODO(msw): mojo/mojo_services.gypi or new mojo_unittest.gypi file ???
+ 'target_name': 'mojo_example_service',
+ # TODO(msw): 'static_library', like mojo_profile_service ???
+ # TODO(msw): 'shared_library', like mojo_surfaces_service ???
+ # TODO(msw): 'executable', like mojo_dbus_echo_service ???
+ # TODO(msw): '<(component)', like mojo_native_viewport_service ???
+ 'type': 'loadable_module',
+ 'dependencies': [
+ '../base/base.gyp:base',
+ 'mojo_application', # For ApplicationDelegate.
+ 'mojo_cpp_bindings', # For example_service.mojom.h
+ 'mojo_environment_standalone', # For Environment.
+ 'mojo_example_service_bindings',
+ 'mojo_utility', # For RunLoop.
+ '<(mojo_system_for_loadable_module)',
+ ],
+ 'sources': [
+ # TODO(msw): Include directly in mojo_example_unittests,
+ # like services/test_service/test_service_impl.cc ???
+ # TODO(msw): Move to examples/services/example/ or elsewhere ???
+ 'examples/test/example_service_application.cc',
+ 'examples/test/example_service_application.h',
+ 'examples/test/example_service_impl.cc',
+ 'examples/test/example_service_impl.h',
+ 'public/cpp/application/lib/mojo_main_standalone.cc',
+ ],
+ },
+ { # TODO(msw): New mojo_unittest.gypi file ???
+ 'target_name': 'mojo_example_unittests',
+ 'type': 'loadable_module',
+ 'dependencies': [
+ '../base/base.gyp:base',
+ '../base/base.gyp:test_support_base',
+ '../testing/gtest.gyp:gtest',
+ 'mojo_application', # For ApplicationDelegate.
+ 'mojo_environment_standalone', # For Environment.
+ 'mojo_example_service',
+ 'mojo_example_service_bindings', # TODO(msw): Needed explicitly?
+ 'mojo_service_manager', # TODO(msw): ServiceManager ???
+ 'mojo_shell_lib', # For shell::InitializeLogging.
+ #'mojo_shell_test_support', # TODO(msw): Needed ???
Ben Goodger (Google) 2014/07/18 20:02:52 My rule of thumb for these things is if I ever am
msw 2014/07/21 18:58:23 I've been careful to only include necessary depend
Ben Goodger (Google) 2014/07/21 20:02:38 See earlier comment about not using ShellTestHelpe
+ #'mojo_shell_tests', # TODO(msw): ShellTestBase ???
+ 'mojo_utility', # For RunLoop.
+ '<(mojo_system_for_loadable_module)',
+ ],
+ 'sources': [
+ # TODO(msw): Move to examples/services/example or elsewhere ???
+ 'examples/test/example_unittest.cc',
+ 'public/cpp/application/lib/mojo_main_standalone.cc',
+ ],
+ },
+ {
+ 'target_name': 'package_mojo_example_unittests',
+ 'variables': {
+ 'app_name': 'mojo_example_unittests',
+ },
+ 'includes': [ 'build/package_app.gypi' ],
+ },
+ {
'target_name': 'mojo_compositor_app',
'type': 'loadable_module',
'dependencies': [
« mojo/examples/test/example_unittest.cc ('K') | « mojo/mojo.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698