Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Issue 399653002: Rework CORS <link rel=stylesheet> tests as js-tests. (Closed)

Created:
6 years, 5 months ago by sof
Modified:
6 years, 5 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Rework CORS <link rel=stylesheet> tests as js-tests. Attempt to get at the flakiness exhibited by one or more of these tests, on Windows mainly. R=tyoshino@chromium.org BUG=394208 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178341

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move up window.test_count assignment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+241 lines, -140 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/security/link-crossorigin-stylesheet-anonymous.html View 1 chunk +28 lines, -17 lines 0 comments Download
M LayoutTests/http/tests/security/link-crossorigin-stylesheet-anonymous-expected.txt View 1 chunk +10 lines, -4 lines 0 comments Download
M LayoutTests/http/tests/security/link-crossorigin-stylesheet-no-cors.html View 1 2 chunks +27 lines, -17 lines 0 comments Download
M LayoutTests/http/tests/security/link-crossorigin-stylesheet-no-cors-expected.txt View 1 chunk +11 lines, -10 lines 0 comments Download
M LayoutTests/http/tests/security/link-crossorigin-stylesheet-use-credentials.html View 1 chunk +29 lines, -17 lines 0 comments Download
M LayoutTests/http/tests/security/link-crossorigin-stylesheet-use-credentials-expected.txt View 1 chunk +10 lines, -4 lines 0 comments Download
M LayoutTests/http/tests/security/link-crossorigin-subresource-anonymous.html View 1 chunk +29 lines, -17 lines 0 comments Download
M LayoutTests/http/tests/security/link-crossorigin-subresource-anonymous-expected.txt View 1 chunk +10 lines, -4 lines 0 comments Download
M LayoutTests/http/tests/security/link-crossorigin-subresource-no-cors.html View 1 chunk +29 lines, -17 lines 0 comments Download
M LayoutTests/http/tests/security/link-crossorigin-subresource-no-cors-expected.txt View 1 chunk +10 lines, -4 lines 0 comments Download
M LayoutTests/http/tests/security/link-crossorigin-subresource-use-credentials.html View 1 chunk +29 lines, -17 lines 0 comments Download
M LayoutTests/http/tests/security/link-crossorigin-subresource-use-credentials-expected.txt View 1 chunk +10 lines, -4 lines 0 comments Download
M LayoutTests/http/tests/security/resources/link-crossorigin-common.js View 2 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
sof
Please take a look. Somewhat speculative attempt to get at the flakiness that these tests ...
6 years, 5 months ago (2014-07-16 21:48:49 UTC) #1
tyoshino (SeeGerritForStatus)
lgtm https://codereview.chromium.org/399653002/diff/1/LayoutTests/http/tests/security/link-crossorigin-stylesheet-no-cors.html File LayoutTests/http/tests/security/link-crossorigin-stylesheet-no-cors.html (right): https://codereview.chromium.org/399653002/diff/1/LayoutTests/http/tests/security/link-crossorigin-stylesheet-no-cors.html#newcode6 LayoutTests/http/tests/security/link-crossorigin-stylesheet-no-cors.html:6: <script>window.test_count = 8;</script> it seems link-crossorigin-common.js is expecting ...
6 years, 5 months ago (2014-07-17 04:04:12 UTC) #2
sof
Thanks for the review. https://codereview.chromium.org/399653002/diff/1/LayoutTests/http/tests/security/link-crossorigin-stylesheet-no-cors.html File LayoutTests/http/tests/security/link-crossorigin-stylesheet-no-cors.html (right): https://codereview.chromium.org/399653002/diff/1/LayoutTests/http/tests/security/link-crossorigin-stylesheet-no-cors.html#newcode6 LayoutTests/http/tests/security/link-crossorigin-stylesheet-no-cors.html:6: <script>window.test_count = 8;</script> On 2014/07/17 ...
6 years, 5 months ago (2014-07-17 07:03:18 UTC) #3
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 5 months ago (2014-07-17 07:03:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/399653002/20001
6 years, 5 months ago (2014-07-17 07:04:30 UTC) #5
Mike West
LGTM2, sorry I'm late. :)
6 years, 5 months ago (2014-07-17 07:30:18 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-17 08:20:28 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 08:59:01 UTC) #8
Message was sent while issue was closed.
Change committed as 178341

Powered by Google App Engine
This is Rietveld 408576698